Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Strings.truncate with length '1' #8
Conversation
… blank array immediately
|
Thanks |
Describe the change
Fixes an issue where passing a truncate value of 1 results in an unhandled exception.
vs
Why are we doing this?
Unhandled exceptions are generally bad :)
Related to piotrmurach/tty-table#20
Benefits
Better handling for all cases on Strings::Truncate
Drawbacks
None that I can see.
Requirements
Put an X between brackets on each line if you have done the item:
[x] Tests written & passing locally?
[x] Code style checked?
[x] Rebased with
masterbranch?[x] Documentaion updated?