Cartesian product with an empty set should be an empty set #339

GrosSacASac · 2019-04-15T16:12:26Z

https://github.com/trekhleb/javascript-algorithms/blob/master/src/algorithms/sets/cartesian-product/cartesianProduct.js#L8

I think it makes more sense to return an empty array

// invalid input return null or throw an error
if (!setA || !setB) {
    return null;
}
if (!setA.length || !setB.length) {
    return []; 
}
// or do nothing since the for loop will not trigger anyway

mik-laj · 2019-06-22T08:48:06Z

Can you create a PR that will introduce this change?

GrosSacASac · 2019-06-22T13:36:20Z

#363

GrosSacASac · 2019-10-01T16:10:46Z

could you have a look ?

blondieblue-eyes · 2020-01-31T18:23:23Z

I need to find out how to unlink or unhack every device help

lazarljubenovic · 2020-01-31T18:37:14Z

You're lost, bud.

blondieblue-eyes · 2020-01-31T18:42:30Z

very t.y.

…

On Fri, Jan 31, 2020, 1:37 PM Lazar Ljubenović ***@***.***> wrote: You're lost, bud. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#339?email_source=notifications&email_token=AONWKKSRNFJ2YNZI3RNLTS3RARVVZA5CNFSM4HGBN2C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPSYPQ#issuecomment-580856894>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AONWKKWLAJ5ADT3BTRJK543RARVVZANCNFSM4HGBN2CQ> .

blondieblue-eyes · 2020-01-31T21:05:30Z

like I need to start somewhere I think maybe start with how to understand the html? On Fri, Jan 31, 2020, 1:42 PM Taste Rainbow <tastetherainbow2day@gmail.com> wrote:

…

very t.y. On Fri, Jan 31, 2020, 1:37 PM Lazar Ljubenović ***@***.***> wrote: > You're lost, bud. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#339?email_source=notifications&email_token=AONWKKSRNFJ2YNZI3RNLTS3RARVVZA5CNFSM4HGBN2C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPSYPQ#issuecomment-580856894>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AONWKKWLAJ5ADT3BTRJK543RARVVZANCNFSM4HGBN2CQ> > . >

This comment was marked as resolved.

Sign in to view

trekhleb / javascript-algorithms

Cartesian product with an empty set should be an empty set #339

Cartesian product with an empty set should be an empty set #339

GrosSacASac commented Apr 15, 2019

mik-laj commented Jun 22, 2019

GrosSacASac commented Jun 22, 2019

GrosSacASac commented Oct 1, 2019

This comment was marked as resolved.

blondieblue-eyes commented Jan 31, 2020

lazarljubenovic commented Jan 31, 2020

blondieblue-eyes commented Jan 31, 2020

blondieblue-eyes commented Jan 31, 2020

trekhleb / javascript-algorithms

Join GitHub today

Cartesian product with an empty set should be an empty set #339

Cartesian product with an empty set should be an empty set #339

Comments

GrosSacASac commented Apr 15, 2019

mik-laj commented Jun 22, 2019

GrosSacASac commented Jun 22, 2019

GrosSacASac commented Oct 1, 2019

This comment was marked as resolved.

blondieblue-eyes commented Jan 31, 2020

lazarljubenovic commented Jan 31, 2020

blondieblue-eyes commented Jan 31, 2020

blondieblue-eyes commented Jan 31, 2020