Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to merge Epochs #458

Merged
merged 1 commit into from Apr 23, 2020
Merged

Rename to merge Epochs #458

merged 1 commit into from Apr 23, 2020

Conversation

@sgugger
Copy link
Contributor

@sgugger sgugger commented Apr 23, 2020

In order to merge the epochs PR, we need to temporarily rename Collatable and concurrentMap to avoid conflicts with the same struct/extension in Epochs.

This PR underscores them, we can undo that in the applications once the epochs PR is merged and in the nightlies.

@sgugger sgugger requested a review from BradLarson Apr 23, 2020
Copy link
Member

@BradLarson BradLarson left a comment

Makes sense as a first step.

@sgugger sgugger merged commit 9b404f3 into tensorflow:master Apr 23, 2020
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
kokoro Kokoro build finished
Details
@sgugger sgugger deleted the sgugger:prepare_epochs branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants