Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade "aws-xray-sdk-core" #529

Merged
merged 1 commit into from May 7, 2020
Merged

Conversation

@abetomo
Copy link
Contributor

abetomo commented May 7, 2020

fix #528

% node --trace-warnings ./bin/node-lambda run
Running index.handler
==================================
event { key: 'value', key2: 'value2', other_key: 'other_value' }
==================================
Stopping index.handler
Success:
(node:10036) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:814:11)
    at Object.get (internal/modules/cjs/loader.js:825:5)
    at Object.exports.setLevels (/pathto/node-lambda/node_modules/winston/lib/winston/common.js:35:14)
    at Object.<anonymous> (/pathto/node-lambda/node_modules/winston/lib/winston.js:83:8)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)

'winston' was the cause.
I upgraded 'aws-xray-sdk-core' because it was dependent on 'winston'.
(Relatedly, 'winston' is also getting an upgrade.)

Not directly related to the warning, but I've also upgraded packages other than 'aws-xray-sdk-core'.

```
% node --trace-warnings ./bin/node-lambda run
Running index.handler
==================================
event { key: 'value', key2: 'value2', other_key: 'other_value' }
==================================
Stopping index.handler
Success:
(node:10036) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:814:11)
    at Object.get (internal/modules/cjs/loader.js:825:5)
    at Object.exports.setLevels (/pathto/node-lambda/node_modules/winston/lib/winston/common.js:35:14)
    at Object.<anonymous> (/pathto/node-lambda/node_modules/winston/lib/winston.js:83:8)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)
```

'winston' was the cause.
I upgraded 'aws-xray-sdk-core' because it was dependent on 'winston'.
(Relatedly, 'winston' is also getting an upgrade.)

Not directly related to the warning, but I've also upgraded packages other than 'aws-xray-sdk-core'.
@DeviaVir DeviaVir merged commit 42ad7c6 into motdotla:master May 7, 2020
9 checks passed
9 checks passed
Test on node 10.x and ubuntu-latest
Details
Test on node 10.x and windows-latest
Details
Test on node 10.x and macos-latest
Details
Test on node 12.x and ubuntu-latest
Details
Test on node 12.x and windows-latest
Details
Test on node 12.x and macos-latest
Details
Test on node 14.x and ubuntu-latest
Details
Test on node 14.x and windows-latest
Details
Test on node 14.x and macos-latest
Details
@abetomo abetomo deleted the abetomo:feature/fix_node_warning branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.