Skip to content

/ deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to manual web page in README.md #5284

Merged
merged 3 commits into from May 13, 2020
Merged

Fix broken links to manual web page in README.md #5284

merged 3 commits into from May 13, 2020
+3 −3

Conversation

@itsrainingmani
Copy link
Contributor

itsrainingmani commented May 13, 2020

The current links to the manual web page in the README.md file include the .html extension but this leads to a 404.

Removing the .html fixes this error and leads to the right webpage.
@itsrainingmani
Fix broken links to manul web page
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b1dcdb9 
The current link to the manual web page includes the `.html` extension but this leads to a 404. Removing the `.html` leads to the right webpage.
@CLAassistant
Copy link

CLAassistant commented May 13, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@bartlomieju
fmt
Loading status checks…
4ddcc0f
@alshakero alshakero mentioned this pull request May 13, 2020
Closed
@bartlomieju
reset CI
Loading status checks…
f5bc25f
@piscisaureus
piscisaureus approved these changes May 13, 2020
View changes
Copy link
Member

piscisaureus left a comment

Thanks!
@piscisaureus piscisaureus merged commit d397b86 into denoland:master May 13, 2020
7 checks passed
7 checks passed
test_release macOS-latest
Details
test_release windows-2019
Details
test_release ubuntu-16.04
Details
test_debug ubuntu-16.04
Details
bench ubuntu-16.04
Details
lint ubuntu-16.04
Details
license/cla Contributor License Agreement is signed.
Details
@itsrainingmani
Copy link
Contributor Author

itsrainingmani commented May 13, 2020 •
edited

Happy to help! Thank you for merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@itsrainingmani @CLAassistant @piscisaureus @bartlomieju
You can’t perform that action at this time.