Add format placeholder for asset URLs and labels #2519
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorbits
force-pushed
the
placeholder-for-asset-urls
branch
2 times, most recently
from
7754f89
to
213c40c
Compare
For automated deployment it is useful to get the asset URL after creating a release, but with the existing asset list placeholder (%as) we get both the URL and its label, separated by a horizontal tab character, this is even when the label is empty, requiring us to post-process the output from `hub release show --format %as <TAG>`. This commit introduces a new placeholder (%au) which allows us to obtain the URL without having to do any parsing. For consistency we also add a placeholder for asset labels (%al).
sorbits
force-pushed
the
placeholder-for-asset-urls
branch
from
213c40c
to
b9694a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For automated deployment it is useful to get the asset URL after creating a release, but with the existing asset list placeholder (
%as) we get both the URL and its label, separated by a horizontal tab character, this is even when the label is empty, requiring us to post-process the output fromhub release show --format %as <TAG>.This commit introduces a new placeholder (
%au) which allows us to obtain the URL without having to do any parsing.For consistency we also add a placeholder for asset labels (
%al).