Support method type in "-only" regular expression option #35

clamoriniere · 2016-11-28T19:23:17Z

Currently with the option “-only” it is not possible to provide the “struct type” in the regular expression.

example:

type structA struct {
   name string
}

type structB struct {}

func (s structA) PrintName() string {
   return “structA” + s.name
}

func (s structB) PrintName() string {
   return “structB”
}

func (s *structA) SetName(n string) string {
    s.name = n
}

if we run gotests -only PrintName it will generate the unit-tests for both functions

it could be interesting to support also the struct type in the regular expression like this: gotests -only structA.PrintName or gotests -only (structA).SetName

or create a new option: “-exact”: gotests -exact (structA).PrintName or gotests -exact structA.PrintName

avgeorge · 2018-10-24T16:39:42Z

This is actually already supported for both "-only" and "-excl", but it is a bit awkward to use. The command for your example would be gotests -only StructAPrintName.
The regexes are matched against a functions "FullName" which includes the receiver type.

gotests/internal/models/models.go

Lines 121 to 127 in c51312f

    
           func (f *Function) FullName() string { 
        
           	var r string 
        
           	if f.Receiver != nil { 
        
           		r = f.Receiver.Type.Value 
        
           	} 
        
           	return strings.Title(r) + strings.Title(f.Name) 
        
           }

However the "FullName" uses title case for both receiver type and function name, and has no separator. Maybe it should be changed to match your example of structA.PrintName?

sunliver · 2019-03-15T08:03:56Z

@avgeorge
I've found an interesting case.
Considering as follows,

package main

type foobar struct{}
type fooBar struct{}
type Foobar struct{}
type FooBar struct{}
func (a foobar) Func() {}
func (a fooBar) Func() {}
func (a Foobar) Func() {}
func (a FooBar) Func() {}
func Func() {}
func main() {}

gotests -only foobarFunc . and gotests -only fooBarFunc . have no output, but
gotests -only FoobarFunc . will generate tests both for type Foobar(TestFoobar_Func) and foobar(Test_foobar_Func)
gotests -only FooBarFunc . will generate tests both for type FooBar(TestFooBar_Func) and fooBar(Test_fooBar_Func).

I don't know whether the output is in the plan or not.

clamoriniere mentioned this issue Nov 29, 2016

Fix "gotests" when generates test for current function microsoft/vscode-go#656

Closed

cweill added the enhancement label Oct 10, 2017

cweill added help wanted good first issue labels Mar 16, 2018

db47h mentioned this issue Sep 3, 2018

Generating unit tests for receiver function generates tests for other types, too microsoft/vscode-go#1880

Closed

Guitarbum722 mentioned this issue Jan 28, 2019

Unit test generation should consider the receiver type microsoft/vscode-go#2282

Closed

cweill / gotests

Support method type in "-only" regular expression option #35

Support method type in "-only" regular expression option #35

clamoriniere commented Nov 28, 2016 •

edited

avgeorge commented Oct 24, 2018

sunliver commented Mar 15, 2019

cweill / gotests

Join GitHub today

Support method type in "-only" regular expression option #35

Support method type in "-only" regular expression option #35

Comments

clamoriniere commented Nov 28, 2016 • edited

avgeorge commented Oct 24, 2018

sunliver commented Mar 15, 2019

Essential cookies

Always active

Analytics cookies

clamoriniere commented Nov 28, 2016 •

edited