Skip to content

/ SkeletonView

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Skeleton view when added programatically in UITableViewCell #276

Closed
anoop4real opened this issue Mar 13, 2020 · 5 comments
Closed

[Documentation] Skeleton view when added programatically in UITableViewCell #276

anoop4real opened this issue Mar 13, 2020 · 5 comments
Assignees
@Juanpe
Labels
✅ fixed 💡 enhancement

Comments

@anoop4real
Copy link

@anoop4real anoop4real commented Mar 13, 2020 •
edited

This is not an issue but an observation. I no longer use storyboards for my view. Today I faced an issue with Skeletonview when I added it to my UITableViewCell, animations, frames everything was working wrong... did a lot of permutation combinations turning the properties on and off. Finally found that when you add elements in UITableViewCell you should add it to contentView and not to the cell ie

    contentView.addSubview(titleLabel) not         self.addSubview(titleLabel)

It would be great if you add this as a note to the documentation (I couldnt find it, may be its already there :) )
@pennywise94
Copy link

@pennywise94 pennywise94 commented Mar 21, 2020

This might be relevant for you:
#125
@Lihuo
Copy link

@Lihuo Lihuo commented Aug 11, 2020

@anoop4real , you save me a lot of time 👍
@Juanpe Juanpe self-assigned this Sep 8, 2020
@Juanpe
Copy link
Owner

@Juanpe Juanpe commented Sep 8, 2020

Hi, good idea I'm going to specify this in the README file. More people could be having this problem
@Juanpe
Copy link
Owner

@Juanpe Juanpe commented Sep 11, 2020

Hi, the README file has been updated including this info 🙂

You can check it here: https://github.com/Juanpe/SkeletonView#-collections
@Juanpe Juanpe closed this Sep 11, 2020
@Juanpe Juanpe added the ✅ fixed label Sep 11, 2020
@anoop4real
Copy link
Author

@anoop4real anoop4real commented Sep 11, 2020

Great 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Juanpe Juanpe

Labels
✅ fixed 💡 enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@Juanpe @anoop4real @pennywise94 @Lihuo
You can’t perform that action at this time.