case insensitive check for the content-length header #8239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 2616 and 7230, headers names are case insensitive. When creating a new session, the webdriver server is checking the request for a case sensitive Content-Type header. This causes the body to be empty on session creation and will result in the IEDriverServer complaining about missing capabilities. This change will search for the Content-Type in a case insensitive manner before capturing the value of the header. Fixes SeleniumHQ#7986
|
|
Contributor
Author
|
I was unsure of where to add tests for this. If someone would be willing to point me in the right direction, I will happily add some if it is needed. I do believe many of the existing tests will cover this change when creating a new webdriver session. |
Member
|
Merged as 2dfe468. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to RFC 2616 and 7230, headers names are case insensitive.
When creating a new session, the webdriver server is checking the
request for a case sensitive Content-Type header. This causes the body
to be empty on session creation and will result in the IEDriverServer
complaining about missing capabilities.
This change will search for the Content-Type in a case insensitive
manner before capturing the value of the header.
Fixes #7986
Motivation and Context
Many modern JavaScript HTTP libraries set their headers to lower case before doing a request. Because IEDriverServer is looking for the
Content-Typein a case sensitive manner, this prevents those tools from testing on IE.Types of changes
Checklist