Skip to content

/ parallel-ssh

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: timeout option for open_session #149

Open
tsarvela opened this issue Oct 30, 2018 · 1 comment
Open

Feature request: timeout option for open_session #149

tsarvela opened this issue Oct 30, 2018 · 1 comment
Labels
enhancement good first issue

Comments

@tsarvela
Copy link

@tsarvela tsarvela commented Oct 30, 2018

Feature request

The asynchronous functionality of parallel-ssh is very much appreciated for management tasks. Thank you for this!

For the feature request:

It seems that the open_session() can keep worker allocated for much longer than expected in failure cases. Would it be reasonable to stretch the timeout option of wait_socket() to open_session() ?
@pkittenis
Copy link
Member

@pkittenis pkittenis commented Oct 30, 2018

Hi there,

Thanks for the interest and report!

Yes, it looks like timeout is not passed on to open_session and would be good to add.

PRs always welcome if anyone is up for it, or can wait for next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@pkittenis @tsarvela
You can’t perform that action at this time.