Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMore clear hooks warning for why a function is not considered as a component #17736
Comments
|
I also found that when writing the demo in the codesandbox, it gives me a warning that I am using hooks into a normal function(because I am using the lowercase letter to start my component name) and it is wrong. |
|
I believe your issue is just requesting a wording change to the hooks lint rule, right? I don't think you're actually suggesting React should "enforce component name to start with Capital Letter" - just that the hooks warning should make it more clearer why it thinks your function isn't a React component? If so, maybe you could re-word the issue title? |
|
@bvaughn yeah, I want to get more specific warning. I will rename the issue. |
aditya81070
changed the title
|
I'd like to give this a shot, if thats ok |
|
@yadedjo It's yours. Let us know if you change your mind so I can change the tag back to being up for grabs :) |
|
Oh, I forgot to mention I was working on it, sorry |
|
@Nilomiranda No worries |
|
can I work on the issue? @yadejo
I have made some changes already in that case. ran the test cases as well. |
|
@albseb511 There's an open PR for this (#17744) it just hasn't been reviewed. |
|
@bvaughn |
|
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
|
@bvaughn the PR hasn't encorporated the requested changes (been over 30 days). Can I raise another updated PR for this issue? |
|
Sure. |
Do you want to request a feature or report a bug?
bug
What is the current behavior?
In current behaviour, I can create a functional component that starts with lowercase and I can use it by importing it with the uppercase name. But if I start using hooks in this lowercase named component, React will give error
React Hook "useState" is called in function "login" which is neither a React function component or a custom React Hook function react-hooks/rules-of-hooks.If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
Reproduce bug here
What is the expected behavior?
The expected behaviour is that I should get a warning at the first point when I am creating a component which starts with lowercase and if I am using hooks into a functional component that starts with lowercase then it should give useful warning something like
start component with uppercase.I know as a developer that I should always start my component with Uppercase letter. But if by mistake someone creates a component with a lowercase letter and tries to use hooks, he will have no clue what is wrong with his code.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
"react": "^16.12.0",
"react-dom": "^16.12.0",
"react-scripts": "3.3.0"
Chrome: 79.0.3945.88 (Official Build) (64-bit)
OS: Ubuntu 18.04.3 LTS x86_64