Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sample config.yml during first start #162

Open
pm-pm opened this issue Mar 13, 2019 · 4 comments
Open

Create sample config.yml during first start #162

pm-pm opened this issue Mar 13, 2019 · 4 comments

Comments

@pm-pm
Copy link

@pm-pm pm-pm commented Mar 13, 2019

During first start the directorys "images" and "plugins" and the db are created, but no default config.yml file.

images/
plugins/
gotify.db

It yould be very helpful (not onyl for beginners) to create a sample/default config.yml in the same directory where the binary is.

@eternal-flame-AD
Copy link
Member

@eternal-flame-AD eternal-flame-AD commented Mar 13, 2019

But we would have no idea on whether you want your config file to be placed in working dir or /etc/gotify/, also I cannot predict whether you might want to use environment variables for configuration.

But I think we can include a default config in the release package, so when you decompress the archive the config file is extracted as well.

@pm-pm
Copy link
Author

@pm-pm pm-pm commented Mar 13, 2019

I propose to create it in the same directory where the gotify "data/" folder which its subfolders is created. So all relevant folders, datas and configs are in the same place.

(When you create an official *.deb file then you can place the config file in "/etc/gotify".)

Having a sample config file in the release package would be a "quick win". Good idea.

@eternal-flame-AD
Copy link
Member

@eternal-flame-AD eternal-flame-AD commented Mar 13, 2019

I still prefer my solution.
The data directory does not necessarily exist: current references to that directory are only in the default configuration and user might want to override that.

@jmattheis
Copy link
Member

@jmattheis jmattheis commented Mar 14, 2019

I agree with @eternal-flame-AD, lets include a default-config.yml in the zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.