Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename lookout-sdk binary to lookout-tool #447
Conversation
|
@dpordomingo how did you convert svg to png originally? I used ImageMagick and it looks different. |
|
I did it the hacky way: screenshot → save as convert \
docs/assets/lookout-sdk-seq-diagram.svg
lookout-sdk-seq-diagram.pngBut these other alternatives render better PNGs (specially CairoSVG), but we should find the better options to do it. $ svgexport docs/assets/lookout-sdk-seq-diagram.svg \
docs/assets/lookout-sdk-seq-diagram.png \
"svg{background:white;}"$ inkscape -z -e docs/assets/lookout-sdk-seq-diagram.png \
--export-background white \
docs/assets/lookout-sdk-seq-diagram.svg$ cairosvg -f png --output-width 900 \
--output docs/assets/lookout-sdk-seq-diagram.png \
docs/assets/lookout-sdk-seq-diagram.svgI think we could move this to a new issue, and apply its decision in all our projects. |
|
@carlosms @dpordomingo according to David's comment we can keep png as it is right now. |
|
We could improve the images in a different PR. But to be honest they look worse, the text typography or kerning makes it harder to read. Why don't we use the same hacky screenshot for this PR, this way we are not in a hurry to find a good way to render them automatically? |
|
@carlosms updated using screenshot |
|
Inside of |
|
thanks @dpordomingo ! fixed |
|
LGTM |
|
rebased on master + squshed docs commits. Merging after CI is green. |
smacker commentedJan 4, 2019
Fix: #412