Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate normalize.css and change how we include it #882
Conversation
|
I deleted the @houndci comments since you marked that file as excluded (probably to avoid more Hound comments). Should we place the normalize.css in the vendor folder instead of the app folder? |
Good thinking! We don’t have a |
|
@tysongach Rails already loads up and checks for a vendor folder by default. So, you're all good. |
|
@BenMorganIO Is that still the case with a Rails Engine, though? |
|
Errr... That's a good question. If we require it from administrate, it should still work... Administrate itself should be aware of a vendor folder. BUT an application should not be fully aware of Administrates vendor folder when it searches a tree. So, I'm going to say yes, but we should test that out. I could be completely wrong. |
|
What’s a good way to test that? |
|
To test? Make sure normalize.css gets included :p |
tysongach
force-pushed the
tg-normalize
branch
2 times, most recently
from
688e2b6
to
d4f5fb3
|
d4f5fb3 places |
- Update normalize.css to v7.0.0. - Include normalize.css as raw CSS, instead of through RubyGems because the normalize-rails gem has fallen much behing the release cycle of normalize.css.
|
I've tested this on a fresh Rails 5.1 app and it seems fine. |
nickcharlton
merged commit ec6491a
into
master
* Update normalize.css and change how we include it - Update normalize.css to v7.0.0. - Include normalize.css as raw CSS, instead of through RubyGems because the normalize-rails gem has fallen much behing the release cycle of normalize.css. * Ignore reset directory from scss-lint * Put normalize.css in vendor directory
the normalize-rails gem has fallen much behing the release cycle of
normalize.css.