Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnforce rule 7.9 in eslint (default-param-last) #2106
Conversation
|
I just realized that since this rule isn't in eslint 5, this would in fact be a breaking change - so it can't come in enabled just yet. |
ljharb
added
semver-breaking: guide change
and removed
semver-minor: tighten rules to match guide
labels
|
Ahh I see, sorry, should I drop eslint 5 from the dependencies and you will merge this sometime in the future or is there other way of doing things? |
|
Typically I add all new rules as "off" as I update eslint versions, and leave a TODO comment to enable them - but they are not enabled until the next major release. |
|
@ljharb Understood, let me know if you need anything else from me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vieira commentedOct 3, 2019
Enforces the existing airbnb style guide rule about default parameters coming last in eslint by using default-param-last.
As this rule was introduced in ESLint 6.4.0, I bumped the eslint version in😨
package.jsonbut I am not sure if that is the right thing to do? This is my first PR in this repository.