Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron-Builder #3447

Merged
merged 15 commits into from Feb 27, 2018
Merged

Electron-Builder #3447

merged 15 commits into from Feb 27, 2018

Conversation

@deinok
Copy link
Contributor

deinok commented Dec 26, 2017

Closes #3429

cc: @FrenchBen

@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Jan 7, 2018

ref #3475

@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Jan 7, 2018

Any update on this @FrenchBen ?
I waiting for a merge in order to add support for linux an mac

@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Jan 29, 2018

ping

@FrenchBen

This comment has been minimized.

Copy link
Contributor

FrenchBen commented Jan 29, 2018

The past few days have been a bit hectic - Can you rebase and I'll take a look?
Thanks!

@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Jan 29, 2018

No problem ;)
LGTM - Should work on Windows 10. Packages are saved in ./dist/
Next step is building .deb, .rpm, etc... for linux.

@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Feb 12, 2018

So, any issue with this @jeffdm ?

@FrenchBen FrenchBen merged commit 26abc33 into docker:master Feb 27, 2018
FrenchBen added a commit that referenced this pull request Feb 27, 2018
This reverts commit 26abc33.
@deinok

This comment has been minimized.

Copy link
Contributor Author

deinok commented Feb 27, 2018

Thanks, I will start working on Linux Mac support ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.