Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHttp Assertions does not allow the creation of a body #925
Comments
|
We feel that it's reasonable to want to be able to set the body in certain cases. If you'd like to help out, feel free to open a PR. |
|
Hi @mvdkleijn , I just made changes for the issue, tried to push to a new branch and got 403, do I need some permissions to make PR? |
This sounds like you're new or perhaps I'm misunderstanding? The way you create a PR is by forking the repository to your own copy, create a branch with your changes pushed to it and then use the Github UI to create the PR. Basically that will be a request for us to merge changes from your fork into our original copy. It sounds like you were trying to push to a branch in the main Testify repository which is indeed off limits to all but the maintainers. Hope that helps! |
|
Yeah first time trying to contribute to open source, thanks, it helps :) |
No worries, feel free to ask more if desired. The Github docs also provide a lot of information on how to do things. Once you have the PR in place, I'll take a look and see if anything needs adjustment and once satisfied all looks good, we can merge it. |
|
No worries, it was straight forward. #938 |
Hi,
It seems like the HTTP Assert package does not allow me to specify a body to pass in a POST request for example. Looking at the
HTTPBody()function, the body argument is set tonil:req, err := http.NewRequest(method, url+"?"+values.Encode(), nil)Is this by design, or am I looking at a missing feature?
Cheers,