Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
add uri template to the package #343
Conversation
|
Hi.. are you interested into moving this in here? |
|
What is the use case? |
|
Using it outside of Guzzle I guess? |
I have various projects/packages that I am using it. So once guzzle v7 is out.. my migration path will be a little bit painful. |
|
btw this PR is a followup of this guzzle/guzzle#2440 |
so I just saw on the PR linked above that the phpleague added a UriTemplate.. you could say that someone could use that one.. but it feels weird though that we had to drop ours and I need to install an external package to migrate.. |
gmponos
changed the title
|
im in the same boat as @gmponos also phpleague comes with its own URI contract and what not; installing it specifically for this feature is not really worth it to me, as i already have a pure PSR7 package (guzzle :)) |
| /** | ||
| * @return string|string[]|null | ||
| */ | ||
| public function expand(string $template, array $variables) |
ro0NL
Jun 10, 2020
static would be nice btw :)
static would be nice btw :)
gmponos
Jun 10, 2020
Author
Member
I will give it a try
I will give it a try
gmponos
Jun 15, 2020
Author
Member
done.. feedback is welcome.. :)
done.. feedback is welcome.. :)
ro0NL
Jun 15, 2020
LGTM 😅
LGTM
|
Uri templates has no relation to the PSR-7 package. You cannot even use UriInterface for this. |
|
ive no strong opionion on a separate package, but doesnt anything evolving around URIs more or less fit here? There's UriResolver, UriNormalizer.. and now UriTemplate :D |
That's what drove me submitting a PR here.. Neither I have strong arguments here... I wouldn't mind creating a separate package under guzzle org related with it.. |
|
Created this repo.. https://github.com/guzzle/uri-template will try to during the weekend to move the code there.. Until then if you have any objections/concerns let me know. |
|
I assume the min php version for that repo will be 7.2? |
|
Yes.. that's my intention |
|
Sounds good to me. |
|
This PR can be closed now? |
No description provided.