Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: SyntaxError thrown when entering bigint literal inside multi-line input #31919

Open
mscdex opened this issue Feb 22, 2020 · 10 comments
Open

repl: SyntaxError thrown when entering bigint literal inside multi-line input #31919

mscdex opened this issue Feb 22, 2020 · 10 comments
Labels
good first issue help wanted repl v10.x

Comments

@mscdex
Copy link
Contributor

@mscdex mscdex commented Feb 22, 2020

  • Version: v10.x
  • Platform: all
  • Subsystem: repl

What steps will reproduce the bug?

$ node
> function foo() {
... let n = 10n;
Thrown:
let n = 10n;
           ^

SyntaxError: Unexpected end of input
>

How often does it reproduce? Is there a required condition?

Reproduces all the time.

What is the expected behavior?

Should not cause an exception.

What do you see instead?

An exception.

Additional information

Works on master. Works when run from a script instead of the repl.
@mscdex mscdex added repl v10.x labels Feb 22, 2020
@mscdex
Copy link
Contributor Author

@mscdex mscdex commented Feb 22, 2020

Looks like #27400 would need to be backported?
@thoqbk
Copy link

@thoqbk thoqbk commented Mar 14, 2020

@mscdex can I take up this?
@upatel32
Copy link

@upatel32 upatel32 commented Mar 25, 2020

does this still need work?
@aashutoshrathi
Copy link

@aashutoshrathi aashutoshrathi commented Apr 1, 2020 •
edited

Is this issue still valid?
@HassanRazaMuhammadTufail
Copy link

@HassanRazaMuhammadTufail HassanRazaMuhammadTufail commented Apr 17, 2020

I wanna work on this. can anyone guide me for my first time contribution?
@addaleax
Copy link
Member

@addaleax addaleax commented Apr 17, 2020

Maybe @BridgeAR ?
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Apr 17, 2020

@HassanRazaMuhammadTufail please feel free to reach out to me through my twitter account or email. I'm happy to have a short video session to help you get this backported.
@dongskyler
Copy link

@dongskyler dongskyler commented Apr 22, 2020 •
edited

Does this issue still need input? I'm happy to get involved
@HassanRazaMuhammadTufail
Copy link

@HassanRazaMuhammadTufail HassanRazaMuhammadTufail commented Apr 24, 2020

@HassanRazaMuhammadTufail please feel free to reach out to me through my twitter account or email. I'm happy to have a short video session to help you get this backported.

@BridgeAR I have emailed you. kindly help me out in contributing.
@PreYunk
Copy link

@PreYunk PreYunk commented May 27, 2020

Anyone still working on this issue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted repl v10.x
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
@mscdex @addaleax @thoqbk @BridgeAR @PreYunk @upatel32 @dongskyler @aashutoshrathi @HassanRazaMuhammadTufail
You can’t perform that action at this time.