Hi,
here it is said that Error::TlsFail means we encountered problems during TLS handshake but this error is also returned by other functions e.g one that loads private key
https://github.com/cloudflare/quiche/blob/c726d349120ce72e8f0a00cd5176fd0767325511/src/lib.rs#L475

Will it be a good idea if TlsFail has message

While looking at the code, I noticed there are several failure paths in the QuicPacketBuilderFinalize function that don't result in the current packet metadata being cleaned up. It could have a reference to a stream, which doesn't get released. This will at best leak additional memory, and at worst cause a hang in clean up.

The tutorial in https://github.com/chmorgan/sharppcap/tree/master/Tutorial is currently found on codeproject.com, https://www.codeproject.com/Articles/12458/SharpPcap-A-Packet-Capture-Framework-for-NET, and could use to be updated to:

• Remove mention of airpcap
• Include latest released version
• Update links to GitHub rather than sourceforge
• Mention nuget packages

(I'm sure more)

DtCraft has a built-in reactor for event-driven programming. We will add a chapter discussing the basics in our cookbook.

Background

Currently, we can read Ethernet frames with VLAN-tags, but not generate/create ones. We'd like to be able to generate packets with VLAN-tagged Ethernet frames. More information about tags can be found at https://docs.rs/capsule/latest/capsule/packets/struct.Ethernet.html#8021q and https://docs.rs/capsule/latest/capsule/packets/struct.Ethernet.html#8021ad, including links to specs/

Returns a Result<Option<P>, Error>, but the docs are a bit terse

https://docs.rs/protocol/3.1.4/protocol/wire/stream/struct.Connection.html#method.receive_packet

Attempts to receive a packet

• Is this a non-blocking call?
• What does Ok(None) mean here? Is it an error? If this is non-blocking, does it mean try again later?

The IP Range in the CIDR example should be

192.168.100.0 - 192.168.100.255
instead of
192.168.100.14 - 192.168.100.255

Possible fix:

	fmt.Printf("IP Range:       %s - %s\n", ipnet.IP, last)

https://github.com/vladimirvivien/go-networking/blob/7e0504e0d323ed34694d8ffd49f1ac53df1a8680/ip/cidr/cidr.go#L55

NXOS plugins by default use the vrf management when applying scripts in equipments.
Need to have the option to choose the vrf name or the default one.

hier_config has the ability to load many instances of remediation into a single object tree. This provides the basis for creating reports over large sets of hier_config remediation configs e.g.:

• How many instances of line vty 0 4 are there?
• Provide a merged report of all remediations by tag

Create documentation for this feature set.