Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues #2403

Open
jaimeiniesta opened this issue Mar 12, 2020 · 3 comments
Open

Accessibility issues #2403

jaimeiniesta opened this issue Mar 12, 2020 · 3 comments

Comments

@jaimeiniesta
Copy link

@jaimeiniesta jaimeiniesta commented Mar 12, 2020

🐛 Bug Report

Related to #462

I've run an HTML and Accessibility check on 100 pages from https://v2.docusaurus.io/ - each page was checked using the latest version of W3C Validator for HTML issues, and Deque Axe-core 3.5.2 for Accessibility issues.

Here is the result report per page - the tabs allow to group the common issues on the site:

https://rocketvalidator.com/s/5f7336e6-2ab5-4bcf-bc42-c9627b32ebbe/p

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

Check the pages using the W3C HTML validator, axe-core for Accessibility or other checkers.

Expected behavior

Not finding incorrect HTML markup nor accessibility issues.

Actual Behavior

HTML and A11Y issues found.

Your Environment

n/a

Reproducible Demo

https://rocketvalidator.com/s/5f7336e6-2ab5-4bcf-bc42-c9627b32ebbe/p

@yangshun
Copy link
Member

@yangshun yangshun commented Mar 15, 2020

Thanks for the reports. Most of the violations are code-block/syntax highlighting related and unfortunately we can't really do anything about them. PRs welcome to fix the other issues.

@amimas
Copy link

@amimas amimas commented Mar 18, 2020

I wonder if the code block or syntax highlight related issues need to be opened as separate issues elsewhere.

@jaimeiniesta
Copy link
Author

@jaimeiniesta jaimeiniesta commented Mar 18, 2020

I wonder if the code block or syntax highlight related issues need to be opened as separate issues elsewhere.

In case it helps, I finally chose another template for our documentation site - I run into similar issues for code blocks, fixing was easy: choosing a higher contrast theme, and making scrollable code blocks focusable by the keyboard (tabindex=0).

Also, I'll be happy to provide free accounts on our accessibility scanner for those interested in improving the accessibility of Docusaurus. Just ping me at jaime@rocketvalidator.com and I'll set yo up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.