Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux installation instructions outdated ? #442

Open
jorgheymans opened this issue Jun 21, 2018 · 6 comments
Open

linux installation instructions outdated ? #442

jorgheymans opened this issue Jun 21, 2018 · 6 comments
Milestone

Comments

@jorgheymans
Copy link
Contributor

@jorgheymans jorgheymans commented Jun 21, 2018

the instructions mention to

  • Copy the font configuration file in config/fontconfig/ to either the system font configuration folder (often /etc/fonts/conf.d/) or the font user folder (often ~/.config/fontconfig/conf.d)

but there is no config/fontconfig in the provided archive. I'm on Ubuntu, should i look for another way to install the font ?

@chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Jun 21, 2018

It is located in the repository on the path https://github.com/source-foundry/Hack/blob/master/config/fontconfig/45-Hack.conf

Perhaps we could add this as an option to the linux installer script? The archives are prepared for cross-platform use.

@chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Jun 21, 2018

Though I suppose it wouldn't be a tremendous issue to add a directory with the file to the compressed release archives or push this as a separate file in our releases. Thoughts?

@jorgheymans
Copy link
Contributor Author

@jorgheymans jorgheymans commented Jun 21, 2018

i think the easiest would be to adjust the wording of the documentation and point to the full URI of the fontconfig file in the git repo, no ambiguity. Still, it's funny to grab a config file from master together with a tagged release. It implies that the config file is valid for all versions, not saying that's an issue just pointing it out :)

@chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Jun 21, 2018

That file was a PR in to the project and my understanding is that it is valid for all versions, past and future. Will update docs. Thanks for pointing it out Jorg. Appreciate it.

@jorgheymans
Copy link
Contributor Author

@jorgheymans jorgheymans commented Jun 22, 2018

Thanks Chris. Just noticed there is https://github.com/source-foundry/hack-linux-installer as well so i used that, it worked fine. It would make sense to mention it on the main installation page I think https://github.com/source-foundry/Hack#quick-installation , just like the windows installer is mentioned there. The 'manual' installation instructions would just be a fallback then for those that don't want to use the script.

@chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Jun 22, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.