Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Edge Validation for directed field #2066
Comments
|
What is this blocked by? Is it okay to go ahead and work on? |
|
Theres a method validateDirection() in SchemaElementDefinitionValidator.java that is never used and is commented out. This is within the develop branch already, so it looks like its already been merged. Shall I uncomment it and create a unit test for it? |
|
So I wrote this method and added it in, however the reason this ticket is blocked and it is commented out is that it is a breaking change, as for users who have schemas without direction validation currently, it would throw an exception and require direction. We cannot make breaking changes on minor versions so it will have to wait until V2, however feel free to create a branch and re add this method back in, and add a unit test, and when we get to the point of V2 we can merge it back in. EDIT - For more context see #1980 |
|
Ready for pull request once we get to V2 |
Validation should be added to directed fields in schemas. This will be done as part of work for version 2 as adding in validation would cause breaking changes.