feat: enable swipe to delete in UITableView#262
Closed
boxizen wants to merge 10 commits intoTencent:masterfrom
Closed
feat: enable swipe to delete in UITableView#262boxizen wants to merge 10 commits intoTencent:masterfrom
boxizen wants to merge 10 commits intoTencent:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 61.30% 70.30% +8.99%
==========================================
Files 28 24 -4
Lines 1866 1357 -509
==========================================
- Hits 1144 954 -190
+ Misses 722 403 -319
Continue to review full report at Codecov.
|
ozonelmy
reviewed
Aug 21, 2020
|
|
||
| - (BOOL)tableView:(UITableView *)tableView canEditRowAtIndexPath:(NSIndexPath *)indexPath { | ||
| if (self.node.props[@"editable"]) { | ||
| return self.node.props[@"editable"]; |
Contributor
There was a problem hiding this comment.
needs BOOL type, not objective-c type object
boxizen
requested review from
churchill-zhang,
ilikethese,
siguangli and
zoomchan-cxj
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure:
After enableswipe to delete in iOS: