Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The only way to exit preferences is to click "go back"? #3667

Open
dlamblin opened this issue Mar 20, 2018 · 12 comments
Open

The only way to exit preferences is to click "go back"? #3667

dlamblin opened this issue Mar 20, 2018 · 12 comments

Comments

@dlamblin
Copy link

@dlamblin dlamblin commented Mar 20, 2018

Expected behavior

A cancel button, or clicking on some thing in the left side bar (the word containers)

Actual behavior

You appear stuck until you find the magic behavior link

Information about the Issue

Steps to reproduce the behavior

  1. ...
  2. ...
@FrenchBen
Copy link
Contributor

@FrenchBen FrenchBen commented Mar 20, 2018

back seems like a pretty normal way to do this - You do this every day on your phone, why does it need to be so much different on this app?

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 21, 2018

Most dialogs over the last 30 years have their action buttons at the bottom right not some link on the top left.
Also most left side bars would have some way of going home. There doesn't seem to be a way at least with a new install that has little content on the left. Eg if clicking the gear icon takes you into preferences, maybe clicking it when you're already there would take you back out.

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 21, 2018

Think of it as a user test. If you sat someone who has never seen kitematic down and asked them to, for example, add a repo, watch their interaction. If they check if it's in the preferences find it's not, what do they do next to get back to the initial view? Is it natural and seamless?
Edit: Github on mobile doesn't left me edit comments so I left a few. And they had some typos. Though you can switch to the desktop view.

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 21, 2018

Specifically as to why is it not okay to make a desktop app that expects users to think of it as a phone app, but follows none of the style guides of iOS, Android, not to mention MacOS or Windows (metro?): There simply wasn't any indication of what to expect. The go back link iirc has no bread crumb call out, a left arrow, any icon, a different background color or a separator bar from the content itself. I cannot swipe in from the left for a hamburger icon menu, the static left sidebar is of no help in exiting preferences as it is anyway. I cannot swipe in from the bottom for a back button action. I'm not sure I expected to be able to swipe in any where, but I did attempt to scroll the content up down and left and right just in case I was missing some hidden overflowed content. That wasn't it either.

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 25, 2018

Here's what it looked like at the time I entered the preferences.
as-is
Here's what I was thinking looking at that.
thoughts after entering the preferences
And here's what I was looking for, or expecting. I have some different mock ups, like if that link had been a button like the +New button is, though actually it's not my favorite and I'll spare you.
buttons

@FrenchBen
Copy link
Contributor

@FrenchBen FrenchBen commented Mar 26, 2018

@dlamblin thank you for the detailed shots and pointers. I propose the following improvements:

  • Make the Gear Icon close the preference page if it was previously open
  • Make the Go Back link an actual button

Adding Cancel or Save would mean a complete change in behavior for this pref pane, which I don't have the resources for ATM.

WDYT?

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 27, 2018

I think its a good incremental change set. The button would be a call to action and make the roll over more noticeable. The toggling of the gear is a logical thing I found myself attempting. One thing to note for that is that the menu item for preferences and the command-, (windows uses a hotkey too?) will need to either stay non-toggling, or update the text of the menu item once in preferences. Possibly to "Exit Preferences".

@FrenchBen
Copy link
Contributor

@FrenchBen FrenchBen commented Mar 27, 2018

@dlamblin would you be interested in making those changes?

@dlamblin
Copy link
Author

@dlamblin dlamblin commented Mar 28, 2018

I think my work just booked the next few weekends for not prime time support work. I'll see when I can make time to do it.

@shandheap
Copy link

@shandheap shandheap commented Jun 3, 2018

Hey @dlamblin, are you still working on this? If not, I'd like to work on this issue as my first PR.

@varun878950
Copy link

@varun878950 varun878950 commented May 27, 2020

India’s unemployment rate was a tad higher at 24.3% for the week ended May 24 compared to 24% in the preceding week or the average unemployment rate of 24.2% in the past eight weeks of the lockdown. The unemployment rate stood at 8.8% in March.

However, the labour participation rate fell marginally to 38.7% in the week ended May 24 as against 38.8% recorded in the preceding week after increasing for three consecutive weeks, says the Centre for Monitoring Indian Economy (CMIE) in its weekly report.

@varun878950
Copy link

@varun878950 varun878950 commented May 27, 2020

“The discouraged workers seem to be coming back to look for jobs. This is good news,” CMIE said, adding that the weekly data also suggests that this influx into the labour markets is succeeding in finding jobs.

CMIE, in the normal course, conducts a multi-stratified survey using a monthly sample size of 1,17,000 individuals who are visited in person and interviewed. However, since the lockdown, the sample size has been reduced to 11,000-12,000 individuals and people are being interviewed over phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.