Add the ability to send a promise as an option to spinnies #3

jcarpanelli · 2019-06-04T00:58:50Z

Instead of setting a spinner as succeed/fail using the spinners#fail and spinner#succeed methods, it would be great if spinnies could do this automatically when sending a promise as an option:

spinnies.add('spinner-1', { 
  text: 'Doing X..',
  onPromise: {
    promise: someFunction(arg1, arg2), 
    succeed: { 
      text: 'X succeeded',
      color: 'greenBright'
    },
    fail: {
      ...
    } 
});

jcarpanelli added feature good first issue labels Jun 4, 2019

jcarpanelli changed the title ~~Add the ability to send a promise as option to a spinner~~ Add the ability to send a promise as an option to spinnies Jun 4, 2019

SweetMNM mentioned this issue Sep 2, 2019

Lots of features #17

Open

jcarpanelli / spinnies

Add the ability to send a promise as an option to spinnies #3

Add the ability to send a promise as an option to spinnies #3

jcarpanelli commented Jun 4, 2019

jcarpanelli / spinnies

Join GitHub today

Add the ability to send a promise as an option to spinnies #3

Add the ability to send a promise as an option to spinnies #3

Comments

jcarpanelli commented Jun 4, 2019