[Text] Component needs to respect global semantic colors#13594
Closed
nileshp87 wants to merge 8 commits intomicrosoft:masterfrom
Closed
[Text] Component needs to respect global semantic colors#13594nileshp87 wants to merge 8 commits intomicrosoft:masterfrom
nileshp87 wants to merge 8 commits intomicrosoft:masterfrom
Conversation
nileshp87
changed the title
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4765a203d0d25f4c09eb946b23e06fe50966d59f (build) |
|
|
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Contributor
|
Syncing up offline |
Contributor
|
I would suggest chatting with @paulgildea and/or @dzearing about the behavior here. Originally, if I remember correctly, the assumption was that the Text object would inherit the text color of its parent elements. Not sure if the FluentUI team wants to change that assumption. |
dzearing
approved these changes
Jul 9, 2020
Contributor
|
Hello @dzearing! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
@nileshp87 Looks like you need to update snapshots. |
Member
|
Actually I went ahead and did the updates in the interest of getting this merged (I've been trying to help get old PRs either merged or closed). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit deb02cd:
|
ecraig12345
requested changes
Aug 28, 2020
Member
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Somehow this seems to be causing screener failures with Button, which is really strange because Button doesn't use Text. @dzearing or @khmakoto any ideas? (marking as request changes to ensure it gets fixed)
https://screener.io/v2/dashboard/5e753c387bf3181b00090c18/patch-2
nileshp87
requested review from
Markionium,
Raghurk,
ThomasMichon,
Vitalius1,
lorejoh12,
micahgodbolt,
miroslavstastny,
mtennoe,
pompomon,
xugao and
yiminwu
as code owners
Collaborator
|
@nileshp87, @khmakoto, it looks like this PR is pretty far out of date. It might be a good idea to convert to draft while things get worked out. Also, do we really need all of these requested reviewers? It would help to tidy that up too. Thanks for picking this back up though! |
Member
|
@JustSlone Yeah, I've been working to get rid of merge conflicts and get it back to a good state. Although it might be good to close it and do it from zero again. I'll spin up a new one tomorrow. |
khmakoto
removed request for
Jahnp,
JustSlone,
assuncaocharles,
behowell,
evlevy,
jdhuntington,
joschemd,
jurokapsiar,
kolaps33,
kubkon,
layershifter,
ling1726,
lorejoh12 and
natalieethell
Member
|
Closed in favor of #17252. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Looking at how TextField works, I mimicked the pattern for using semanticColors. However, to leave the old behavior intact I use the semanticColor as a fallback instead of the only option.
Focus areas to test
(optional)