Skip to content

Screen Reader is not announcing the location list items twice.#13600

Closed
Ravishankar9-dev wants to merge 3 commits intomicrosoft:masterfrom
Ravishankar9-dev:user/v-satgar/ScreenReaderAnnouncingTwice
Closed

Screen Reader is not announcing the location list items twice.#13600
Ravishankar9-dev wants to merge 3 commits intomicrosoft:masterfrom
Ravishankar9-dev:user/v-satgar/ScreenReaderAnnouncingTwice

Conversation

@Ravishankar9-dev
Copy link
Copy Markdown

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Removed title for the commandBar for the screen reader to announce the list item only once.

Focus areas to test

N/A

@msft-github-bot
Copy link
Copy Markdown
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 884 911 5000
ButtonNext mount 419 404 5000
Checkbox mount 1631 1560 5000
CheckboxBase mount 1299 1341 5000
CheckboxNext mount 1597 1562 5000
ChoiceGroup mount 4930 4976 5000
ComboBox mount 907 895 1000
CommandBar mount 7204 7138 1000
ContextualMenu mount 11552 11461 1000
DefaultButton mount 1080 1093 5000
DetailsRow mount 3425 3450 5000
DetailsRowFast mount 3483 3556 5000
DetailsRowNoStyles mount 3300 3296 5000
Dialog mount 1507 1488 1000
DocumentCardTitle mount 1706 1647 1000
Dropdown mount 2393 2461 5000
FocusZone mount 1735 1644 5000
IconButton mount 1772 1746 5000
Label mount 325 350 5000
Link mount 497 494 5000
LinkNext mount 520 526 5000
MenuButton mount 1472 1393 5000
Nav mount 3091 3193 1000
Panel mount 1397 1476 1000
Persona mount 778 802 1000
Pivot mount 1386 1353 1000
PivotNext mount 1394 1294 1000
PrimaryButton mount 1214 1340 5000
SearchBox mount 1269 1252 5000
Slider mount 1464 1511 5000
SliderNext mount 1939 1927 5000
Spinner mount 422 407 5000
SplitButton mount 3053 3105 5000
Stack mount 484 523 5000
StackWithIntrinsicChildren mount 1800 1814 5000
StackWithTextChildren mount 4982 5070 5000
TagPicker mount 2756 2718 5000
Text mount 418 422 5000
TextField mount 1401 1433 5000
ThemeProvider mount 2684 2647 5000
ThemeProvider virtual-rerender 494 514 5000
Toggle mount 891 912 5000
ToggleNext mount 887 863 5000
button mount 101 103 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.48 0.98:1 2000 931
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 557
🔧 Checkbox.Fluent 0.62 0.37 1.68:1 1000 621
🦄 Dialog.Fluent 0.14 0.22 0.64:1 5000 712
🔧 Dropdown.Fluent 3.2 0.45 7.11:1 1000 3197
🔧 Icon.Fluent 0.15 0.05 3:1 5000 732
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 369
🔧 Slider.Fluent 1.47 0.33 4.45:1 1000 1471
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 364
🦄 Tooltip.Fluent 0.1 15.05 0.01:1 5000 500

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 384 343 1.12:1
Text.Fluent 364 330 1.1:1
AccordionMinimalPerf.default 147 136 1.08:1
ListCommonPerf.default 942 872 1.08:1
ListNestedPerf.default 888 828 1.07:1
TreeMinimalPerf.default 924 864 1.07:1
Checkbox.Fluent 621 579 1.07:1
AnimationMinimalPerf.default 370 350 1.06:1
ButtonMinimalPerf.default 171 162 1.06:1
FlexMinimalPerf.default 317 298 1.06:1
ItemLayoutMinimalPerf.default 1384 1309 1.06:1
ReactionMinimalPerf.default 404 381 1.06:1
VideoMinimalPerf.default 622 585 1.06:1
Avatar.Fluent 931 878 1.06:1
AttachmentMinimalPerf.default 157 149 1.05:1
BoxMinimalPerf.default 333 317 1.05:1
ChatMinimalPerf.default 624 593 1.05:1
ChatWithPopoverPerf.default 463 443 1.05:1
InputMinimalPerf.default 1039 993 1.05:1
MenuMinimalPerf.default 844 806 1.05:1
TextMinimalPerf.default 350 333 1.05:1
PortalMinimalPerf.default 106 102 1.04:1
Icon.Fluent 732 706 1.04:1
CheckboxMinimalPerf.default 2751 2669 1.03:1
GridMinimalPerf.default 696 676 1.03:1
HierarchicalTreeMinimalPerf.default 413 402 1.03:1
ListWith60ListItems.default 1053 1027 1.03:1
RefMinimalPerf.default 197 192 1.03:1
SplitButtonMinimalPerf.default 4112 4005 1.03:1
AlertMinimalPerf.default 290 284 1.02:1
AttachmentSlotsPerf.default 1137 1112 1.02:1
DialogMinimalPerf.default 736 725 1.02:1
EmbedMinimalPerf.default 1877 1849 1.02:1
ImageMinimalPerf.default 383 377 1.02:1
ListMinimalPerf.default 463 452 1.02:1
MenuButtonMinimalPerf.default 1828 1785 1.02:1
CustomToolbarPrototype.default 3847 3788 1.02:1
ToolbarMinimalPerf.default 914 896 1.02:1
Dropdown.Fluent 3197 3125 1.02:1
CardMinimalPerf.default 578 572 1.01:1
LabelMinimalPerf.default 415 411 1.01:1
SegmentMinimalPerf.default 360 356 1.01:1
StatusMinimalPerf.default 700 695 1.01:1
TableManyItemsPerf.default 2268 2246 1.01:1
TooltipMinimalPerf.default 732 725 1.01:1
Tooltip.Fluent 500 497 1.01:1
AvatarMinimalPerf.default 495 496 1:1
ButtonSlotsPerf.default 598 600 1:1
DropdownManyItemsPerf.default 1359 1358 1:1
LoaderMinimalPerf.default 690 691 1:1
TreeWith60ListItems.default 220 220 1:1
Image.Fluent 369 368 1:1
Slider.Fluent 1471 1465 1:1
ChatDuplicateMessagesPerf.default 428 432 0.99:1
PopupMinimalPerf.default 889 901 0.99:1
ProviderMergeThemesPerf.default 1927 1943 0.99:1
RadioGroupMinimalPerf.default 411 414 0.99:1
DropdownMinimalPerf.default 3174 3243 0.98:1
SliderMinimalPerf.default 1472 1506 0.98:1
DividerMinimalPerf.default 365 378 0.97:1
ProviderMinimalPerf.default 772 797 0.97:1
Dialog.Fluent 712 735 0.97:1
FormMinimalPerf.default 406 423 0.96:1
HeaderSlotsPerf.default 750 779 0.96:1
IconMinimalPerf.default 680 707 0.96:1
TableMinimalPerf.default 393 410 0.96:1
Button.Fluent 557 579 0.96:1
CarouselMinimalPerf.default 453 479 0.95:1
LayoutMinimalPerf.default 392 411 0.95:1
TextAreaMinimalPerf.default 485 522 0.93:1

@JustSlone JustSlone assigned joschect and unassigned jdhuntington Jul 9, 2020
@JustSlone
Copy link
Copy Markdown
Collaborator

@joschect can you take a look at this?

@joschect
Copy link
Copy Markdown
Contributor

@Ravishankar9-dev the comment for this says commandbar but it looks like this is the combobox, did you intend to change a different component?

@msft-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants