Skip to content

/ bootstrap

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stack Overflow tag #31062

Merged
merged 4 commits into from Jun 18, 2020
Merged

Fix Stack Overflow tag #31062

merged 4 commits into from Jun 18, 2020

Conversation

@cstuder
Copy link
Contributor

cstuder commented Jun 17, 2020

Minor documentation fix.
@cstuder
Introduction: Fixes missing version increase
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa7af42
@XhmikosR XhmikosR requested a review from mdo Jun 17, 2020
@XhmikosR XhmikosR added docs v5 labels Jun 17, 2020
@XhmikosR XhmikosR added this to Inbox in v5.0.0-alpha2 via automation Jun 17, 2020
@XhmikosR
Merge branch 'main' into patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0347adb
@XhmikosR
XhmikosR reviewed Jun 18, 2020
View changes
v5.0.0-alpha2 automation moved this from Inbox to Approved Jun 18, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jun 18, 2020

Actually, @cstuder can you update README.md too please?
@XhmikosR XhmikosR self-requested a review Jun 18, 2020
@XhmikosR XhmikosR dismissed their stale review Jun 18, 2020

README

v5.0.0-alpha2 automation moved this from Approved to Review Jun 18, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jun 18, 2020

It seems we have more places:

Search "bootstrap-4" (8 hits in 4 files)
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\.github\CONTRIBUTING.md (2 hits)
	Line 22:   Overflow ([`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag),
	Line 22:   Overflow ([`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag),
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\.github\SUPPORT.md (2 hits)
	Line 11: - Ask and explore Stack Overflow with the [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag.
	Line 11: - Ask and explore Stack Overflow with the [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag.
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\site\content\docs\5.0\getting-started\introduction.md (2 hits)
	Line 125: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
	Line 125: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
  E:\Downloads\Internet Downloads\bootstrap-main\bootstrap-main\README.md (2 hits)
	Line 164: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
	Line 164: - Implementation help may be found at Stack Overflow (tagged [`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4)).
@XhmikosR XhmikosR added the meta label Jun 18, 2020
@cstuder
Copy link
Contributor Author

cstuder commented Jun 18, 2020

Will do, didn't think to check other files too.
cstuder added 2 commits Jun 18, 2020
@cstuder
Docs: Fixes version number in misc. places
Verified
This commit was signed with a verified signature.
cstuder Christian Studer
GPG key ID: 7E24E0F7741F3BE5 Learn about signing commits
Loading status checks…
e2684db
@cstuder
Merge branch 'main' into patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4f933c
@cstuder
Copy link
Contributor Author

cstuder commented Jun 18, 2020

@XhmikosR Done. Please re-review.
@XhmikosR
XhmikosR approved these changes Jun 18, 2020
View changes
Copy link
Member

XhmikosR left a comment

LGTM, thanks!
v5.0.0-alpha2 automation moved this from Review to Approved Jun 18, 2020
@XhmikosR XhmikosR changed the title Introduction: Fixes missing version increase Fix Stack Overflow tag Jun 18, 2020
@XhmikosR XhmikosR merged commit 3a61e1a into twbs:main Jun 18, 2020
10 checks passed
10 checks passed
bundlewatch
Details
css
Details
css
Details
docs
Details
Node 10
Details
lint
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
coverage/coveralls Coverage decreased (-0.06%) to 94.536%
Details
deploy/netlify Deploy preview ready!
Details
v5.0.0-alpha2 automation moved this from Approved to Shipped Jun 18, 2020
@cstuder cstuder deleted the cstuder:patch-1 branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR

@mdo mdo

Assignees
No one assigned
Labels
docs meta v5
Projects
v5.0.0-alpha2
  
Shipped
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cstuder @XhmikosR
You can’t perform that action at this time.