Skip to content

/ PARL

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows compatibility in `log_server_test.py` #293

Merged
merged 2 commits into from Jun 10, 2020
Merged

Fix Windows compatibility in `log_server_test.py` #293

merged 2 commits into from Jun 10, 2020

Conversation

@tanzeyy
Copy link
Collaborator

@tanzeyy tanzeyy commented Jun 10, 2020

Fix Windows compatibility in log_server_test.py
tanzeyy added 2 commits Jun 10, 2020
@tanzeyy
catch `TypeError` in `remote.__del__`
2a842c6
@tanzeyy
`log_server_test.py` windows compatibility
Loading status checks…
48a3ba3
@zenghsh3
zenghsh3 approved these changes Jun 10, 2020
View changes
Copy link
Collaborator

@zenghsh3 zenghsh3 left a comment

LGTM
@zenghsh3 zenghsh3 merged commit 3b6e7a9 into PaddlePaddle:develop Jun 10, 2020
3 checks passed
3 checks passed
Unit Test (PaddlePARL) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenghsh3 zenghsh3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tanzeyy @zenghsh3
You can’t perform that action at this time.