Skaffold modules design proposal#4350
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Jul 7, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4350 +/- ##
=======================================
Coverage 71.74% 71.75%
=======================================
Files 324 324
Lines 12511 12515 +4
=======================================
+ Hits 8976 8980 +4
Misses 2966 2966
Partials 569 569
Continue to review full report at Codecov.
|
tejal29
approved these changes
Jun 19, 2020
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
This looks great! Looks like you have captured all of the user cases nice!
Thank you!
Contributor
|
@balopat please feel free to merge this in once you have resolved all the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please comment on the doc for this design proposal!