Skip to content

/ hyper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain commented out plugins when installing/uninstalling plugins from the cli #2756

Open
timothyis opened this issue Mar 13, 2018 · 2 comments
Open

Retain commented out plugins when installing/uninstalling plugins from the cli #2756

timothyis opened this issue Mar 13, 2018 · 2 comments
Labels
good first issue help wanted 🎨 Type: Enhancement 🦉 Version: Canary

Comments

@timothyis
Copy link
Member

@timothyis timothyis commented Mar 13, 2018 •
edited

  • I am on the latest Hyper.app version (canary)
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: MacOS 10.13.3 (High Sierra)
  • Hyper.app version: Hyper 2.0.0-canary.14 (canary)
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

I tried to comment out three plugins in my .hyper.js config so that I could take screenshots of other plugins and themes that I'd install via the Hyper CLI. Upon either installing or uninstalling the plugin/theme that I was taking a screenshot of, the commented out plugins in my config disappeared and the node_modules pertaining to them also got removed.

Expected Behaviour

Unless specified, plugins commented out should retain
@chabou
Copy link
Collaborator

@chabou chabou commented Mar 13, 2018

node_modulesshould be cleaned, no problem whith that.
But we should keep commented plugins.

It should happen somewhere here:
https://github.com/zeit/hyper/blob/e4cef0a17234f1c99a6a9ef171cea41f7b382163/cli/api.js#L104-L105
@chabou chabou mentioned this issue Mar 27, 2018
Closed
@itaisteinherz
Copy link
Contributor

@itaisteinherz itaisteinherz commented Aug 30, 2018

@timothyis could you try to reproduce this again using the latest version of Hyper?
I just tried adding a commented-out plugin to ~/.hyper.js, and even after installing and uninstalling modules using the hyper binary the comment remains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted 🎨 Type: Enhancement 🦉 Version: Canary
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@timothyis @chabou @itaisteinherz
You can’t perform that action at this time.