Skip to content

/ botframework-sdk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCR: As a developer, I would like to see some documentation to understand how to use the DialogTestClient provided by the framework so I can write unit tests for my bot #5363

Open
gabog opened this issue Apr 9, 2019 · 9 comments
Open

DCR: As a developer, I would like to see some documentation to understand how to use the DialogTestClient provided by the framework so I can write unit tests for my bot #5363

gabog opened this issue Apr 9, 2019 · 9 comments
Assignees
@gabog @Kaiqb
Labels
Testing Framework documentation
Projects
Bot Testing
Milestone
v4.5 Preview

Comments

@gabog
Copy link
Contributor

@gabog gabog commented Apr 9, 2019 •
edited

The new Testing Framework needs to be documented so developers understand how to use it.

The documentation should include:

  • Inline documentation in code for key classes, methods and properties in the testing framework.
  • Redme.md files in CoreBot samples
  • Code comments in CoreBot samples
  • Getting started guide on how to write tests posted to docs.microsoft.com ( created for each supported language under https://aka.ms/cs-unit-test-docs)

Tracking Status for documentation

Dotnet documentation

  • PR
  • Merged

Javascript documentation

  • PR
  • Merged

Python documentation

  • PR
  • Merged

Tracking Status for samples readme

Dotnet Readme

  • PR
  • Merged

Javascript Readme

  • PR
  • Merged

TypeScript Readme

  • PR
  • Merged

Python Readme

  • PR
  • Merged
@gabog gabog created this issue from a note in Bot Testing (New) Apr 9, 2019
@gabog gabog moved this from New to 4.5 Preview Candidates in Bot Testing Apr 10, 2019
@gabog gabog added this to the v4.5 Preview milestone Apr 10, 2019
@gabog gabog added the 4.5 label Apr 10, 2019
@gabog gabog moved this from 4.5 Preview Candidates to New in Bot Testing Apr 11, 2019
@gabog gabog moved this from New to 4.5 Preview Candidates in Bot Testing Apr 12, 2019
@gabog gabog moved this from 4.5 Candidates to Ready in Bot Testing Jun 7, 2019
@gabog gabog changed the title DCR: As a developer, I would like to see some documentation to understand how to use TestAdapter and the Fakes provided by the framework so I can write unit tests for my bot DCR: As a developer, I would like to see some documentation to understand how to use the DialogTestClient provided by the framework so I can write unit tests for my bot Jun 26, 2019
@gabog gabog moved this from Ready to In Progress in Bot Testing Jun 26, 2019
@Kaiqb
Copy link
Contributor

@Kaiqb Kaiqb commented Jul 3, 2019

Content is now staging here: https://review.docs.microsoft.com/en-us/azure/bot-service/test-bot?view=azure-bot-service-4.0&branch=pr-en-us-1588.
@Kaiqb Kaiqb closed this Jul 3, 2019
Bot Testing automation moved this from In Progress to Done Jul 3, 2019
@gabog gabog added 4.6 and removed 4.5 labels Jul 22, 2019
@gabog
Copy link
Contributor Author

@gabog gabog commented Jul 22, 2019

@Kaiqb, reopening this one to be able to track the changes that will be needed for Python in 4.6.
@gabog gabog reopened this Jul 22, 2019
@gabog gabog moved this from Done to In Progress in Bot Testing Jul 22, 2019
@Kaiqb Kaiqb removed the 4.6 label Sep 6, 2019
@Kaiqb
Copy link
Contributor

@Kaiqb Kaiqb commented Sep 6, 2019

@gabog - Python is not going to GA in 4.6. Removing the 4.6 tag.
@gabog gabog added the R7 label Sep 13, 2019
@Kaiqb
Copy link
Contributor

@Kaiqb Kaiqb commented Nov 7, 2019

@gabog - are you planning to update this workitem for Python in R7?
@gabog
Copy link
Contributor Author

@gabog gabog commented Nov 11, 2019

  • @axelsrz, hi Axel, are you planning to write docs as part of Python R7 support for testing dialog?
@axelsrz
Copy link
Member

@axelsrz axelsrz commented Nov 11, 2019 •
edited

@gabog If we have an equivalent doc for C# and JS, yes.
@Kaiqb
Copy link
Contributor

@Kaiqb Kaiqb commented Nov 11, 2019 •
edited

@axelsrz - we do have C# and JS docs. You can see it here. Do you plan to have additional namespaces to support the testing approach outlined in the topic? I just need to confirm that this will land in R7 (December 10th).
@axelsrz
Copy link
Member

@axelsrz axelsrz commented Nov 18, 2019 •
edited

@Kaiqb This is already in master branch, the new library is botbuilder-testing https://github.com/microsoft/botbuilder-python/tree/master/libraries/botbuilder-testing
@Kaiqb Kaiqb removed the R7 label Nov 19, 2019
@Kaiqb Kaiqb added the R8 label Nov 19, 2019
@Kaiqb
Copy link
Contributor

@Kaiqb Kaiqb commented Nov 19, 2019

Thanks! We'll pick this up in R8.
@gabog gabog removed the R8 label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabog gabog

@Kaiqb Kaiqb

Labels
Testing Framework documentation
Projects
Bot Testing
  
In Progress
Milestone
  v4.5 Preview
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@axelsrz @gabog @Kaiqb
You can’t perform that action at this time.