Skip to content

/ escodegen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed precedence of sequence expression in computed property name #415

Merged
merged 5 commits into from Jun 22, 2020
Merged

fixed precedence of sequence expression in computed property name #415

merged 5 commits into from Jun 22, 2020

Conversation

@sanex3339
Copy link
Contributor

@sanex3339 sanex3339 commented Jun 22, 2020

Fixes javascript-obfuscator/javascript-obfuscator#638
@michaelficarra this is a high priority bug for my package. Please check this.
sanex3339
Fixed precedence of sequence expression as method definition key
Loading status checks…
bb0689f
@sanex3339 sanex3339 mentioned this pull request Jun 22, 2020
Closed
sanex3339
Added test to check computed key parenthesis
Loading status checks…
c89ea2f
@michaelficarra
michaelficarra reviewed Jun 22, 2020
View changes
escodegen.js Outdated Show resolved Hide resolved
@michaelficarra
michaelficarra reviewed Jun 22, 2020
View changes
test/compare-acorn-es6/class-declaration.expected.js Outdated Show resolved Hide resolved
sanex3339 added 2 commits Jun 22, 2020
sanex3339
Changed precedence of method definition key on Assignment
Loading status checks…
13e3eb8
sanex3339
Updated test to check computed key parenthesis
Loading status checks…
189e8c5
@michaelficarra
michaelficarra reviewed Jun 22, 2020
View changes
test/compare-acorn-es6/class-declaration.js Outdated Show resolved Hide resolved
sanex3339
Replaced ComputedKeyWithParenthesis test on AssignmentExpressionAsKey…
Loading status checks…
25eb2b8 
… test
@sanex3339 sanex3339 requested a review from michaelficarra Jun 22, 2020
@michaelficarra
michaelficarra approved these changes Jun 22, 2020
View changes
@michaelficarra michaelficarra changed the title Fixed precedence of sequence expression as method definition key fixed precedence of sequence expression in computed property name Jun 22, 2020
@michaelficarra michaelficarra merged commit eee573b into estools:master Jun 22, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sanex3339
Copy link
Contributor Author

@sanex3339 sanex3339 commented Jun 23, 2020

Thank you
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

sequence as class property breaks everything
2 participants
@sanex3339 @michaelficarra
You can’t perform that action at this time.