Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at fixing #311 #333

Merged
merged 3 commits into from Dec 26, 2019
Merged

first pass at fixing #311 #333

merged 3 commits into from Dec 26, 2019

Conversation

@AndrewAnnex
Copy link
Owner

@AndrewAnnex AndrewAnnex commented Dec 25, 2019

need to update doc strings in places

@pep8speaks
Copy link

@pep8speaks pep8speaks commented Dec 25, 2019

Hello @AndrewAnnex! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 17224:89: E501 line too long (112 > 88 characters)
Line 17216:89: E501 line too long (91 > 88 characters)
Line 15274:89: E501 line too long (109 > 88 characters)
Line 15097:89: E501 line too long (170 > 88 characters)
Line 14709:89: E501 line too long (96 > 88 characters)
Line 13275:89: E501 line too long (96 > 88 characters)
Line 13014:89: E501 line too long (96 > 88 characters)
Line 8826:89: E501 line too long (149 > 88 characters)
Line 7604:89: E501 line too long (93 > 88 characters)
Line 7477:89: E501 line too long (149 > 88 characters)
Line 7475:89: E501 line too long (95 > 88 characters)
Line 7473:89: E501 line too long (98 > 88 characters)
Line 7451:89: E501 line too long (92 > 88 characters)
Line 7449:89: E501 line too long (108 > 88 characters)
Line 7411:89: E501 line too long (120 > 88 characters)
Line 6909:89: E501 line too long (96 > 88 characters)
Line 6436:89: E501 line too long (132 > 88 characters)
Line 6434:89: E501 line too long (131 > 88 characters)
Line 6432:89: E501 line too long (152 > 88 characters)
Line 6426:89: E501 line too long (142 > 88 characters)
Line 6424:89: E501 line too long (101 > 88 characters)
Line 6416:89: E501 line too long (105 > 88 characters)
Line 3613:89: E501 line too long (166 > 88 characters)
Line 3566:89: E501 line too long (114 > 88 characters)
Line 3200:89: E501 line too long (89 > 88 characters)
Line 2462:89: E501 line too long (91 > 88 characters)
Line 1413:89: E501 line too long (92 > 88 characters)
Line 1037:89: E501 line too long (109 > 88 characters)
Line 104:89: E501 line too long (91 > 88 characters)

Line 10427:89: E501 line too long (89 > 88 characters)
Line 10426:89: E501 line too long (103 > 88 characters)
Line 6654:89: E501 line too long (89 > 88 characters)
Line 5961:89: E501 line too long (91 > 88 characters)
Line 5540:89: E501 line too long (99 > 88 characters)
Line 5249:89: E501 line too long (119 > 88 characters)
Line 4679:89: E501 line too long (131 > 88 characters)
Line 4024:89: E501 line too long (107 > 88 characters)
Line 3541:89: E501 line too long (144 > 88 characters)
Line 3262:89: E501 line too long (117 > 88 characters)
Line 2882:89: E501 line too long (91 > 88 characters)
Line 1506:89: E501 line too long (124 > 88 characters)
Line 1503:89: E501 line too long (100 > 88 characters)
Line 1488:89: E501 line too long (112 > 88 characters)
Line 1487:89: E501 line too long (97 > 88 characters)
Line 1483:89: E501 line too long (114 > 88 characters)
Line 1359:89: E501 line too long (95 > 88 characters)
Line 1357:89: E501 line too long (116 > 88 characters)
Line 1356:89: E501 line too long (101 > 88 characters)
Line 1352:89: E501 line too long (118 > 88 characters)
Line 1175:89: E501 line too long (92 > 88 characters)
Line 1089:89: E501 line too long (92 > 88 characters)

Comment last updated at 2019-12-26 16:51:49 UTC
@coveralls
Copy link

@coveralls coveralls commented Dec 25, 2019

Coverage Status

Coverage decreased (-0.008%) to 99.79% when pulling d86b036 on fix_numpy_vect_returns into f1ce918 on master.

AndrewAnnex added 2 commits Dec 25, 2019
@AndrewAnnex AndrewAnnex merged commit 78196cf into master Dec 26, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 99.79%
Details
@AndrewAnnex AndrewAnnex deleted the fix_numpy_vect_returns branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.