Skip to content

/ asyncpg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in documentation in connect() parameter server_settings #540

Open
sergeyspatar opened this issue Mar 12, 2020 · 1 comment · May be fixed by #584
Open

Broken link in documentation in connect() parameter server_settings #540

sergeyspatar opened this issue Mar 12, 2020 · 1 comment · May be fixed by #584

Comments

@sergeyspatar
Copy link

@sergeyspatar sergeyspatar commented Mar 12, 2020

In the documentation for connect() function, parameter server_settings has the following description:

An optional dict of server runtime parameters. Refer to PostgreSQL documentation for a list of supported options.

The link in the description returns error 404 Not found.
@samuelcolvin
Copy link
Contributor

@samuelcolvin samuelcolvin commented Jun 5, 2020

The link line is

asyncpg/asyncpg/connection.py

Line 1612 in aa67d61

a `list of supported options <server settings>`_.

But, there is at least one more 404 link on that page:

asyncpg/asyncpg/connection.py

Line 1503 in aa67d61

using `environment variables <postgres envvars>`_.

I think they need changing to

..._>`_
@samuelcolvin samuelcolvin linked a pull request that will close this issue Jun 5, 2020
Open
@aekkasit114 aekkasit114 mentioned this issue Jun 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix connection links
2 participants
@samuelcolvin @sergeyspatar
You can’t perform that action at this time.