deps/zlib is not compatible with clang-cl

[targos]

I'm experimenting with Visual Studio's Clang support and have an issue with deps/zlib:

Details

Project files generated.
  histogram.vcxproj -> ..\..\out\Release\lib\histogram.lib
  v8_libplatform.vcxproj -> ..\..\out\Release\lib\v8_libplatform.lib
  uvwasi.vcxproj -> ..\..\out\Release\lib\uvwasi.lib
  llhttp.vcxproj -> ..\..\out\Release\lib\llhttp.lib
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
crc_folding.c(46,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(46,14): error : expected '(' after 'attribute' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(61,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(88,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(123,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]   
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(164,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]   
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(231,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]   
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(46,1): warning : declaration does not declare anything [-Wmissing-declarations] [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(231,14): error : expected '(' after 'attribute' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(282,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]   
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(231,1): warning : declaration does not declare anything [-Wmissing-declarations] [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj] 
crc_folding.c(439,15): error : too many arguments provided to function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]   
crc_folding.c(27,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(439,14): error : expected '(' after 'attribute' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(505,2): error : expected identifier or '(' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(13,39): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(13,38): error : expected '(' after 'attribute' [ 
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(15,40): error : too many arguments provided to f 
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(15,39): error : expected '(' after 'attribute' [
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(16,34): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(16,33): error : expected '(' after 'attribute' [
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(17,36): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(17,35): error : expected '(' after 'attribute' [
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(18,35): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(18,34): error : expected '(' after 'attribute' [ 
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(30,39): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(30,38): error : expected '(' after 'attribute' [
C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(47,25): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT 
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(64,23): error : too many arguments provided to f 
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(80,25): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT 
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(96,29): error : too many arguments provided to f
unction-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT 
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(126,25): error : too many arguments provided to 
function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT 
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(156,25): error : too many arguments provided to  
function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  In file included from adler32_simd.c:57:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\tmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\pmmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\emmintrin.h:13:
  In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\xmmintrin.h:13:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(186,25): error : too many arguments provided to 
function-like macro invocation [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\Llvm\lib\clang\10.0.0\include\mmintrin.h(21,42): message : expanded from macro '__DEFAULT 
_FN_ATTRS' [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
adler32_simd.c(54,9): message : macro '__attribute__' defined here [C:\Users\targo\Documents\Git\nodejs\node\deps\zlib\zlib.vcxproj]
  fatal error: too many errors emitted, stopping now [-ferror-limit=]

/cc @addaleax

Diff to generate a solution that uses Clang:

diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
index 09abadb1bc..1c960aefca 100644
--- a/tools/gyp/pylib/gyp/generator/msvs.py
+++ b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2799,7 +2799,7 @@ def _GetMSBuildLocalProperties(msbuild_toolset):
   if msbuild_toolset:
     properties = [
         ['PropertyGroup', {'Label': 'Locals'},
-          ['PlatformToolset', msbuild_toolset],
+          ['PlatformToolset', 'ClangCL'],
         ]
       ]
   return properties

Note that other parallel builds went fine (libuv, cares, even v8_zlib), so maybe we're not far from Clang support on Windows!

[targos]

Line 21 of mmintrin.h:

#define __DEFAULT_FN_ATTRS __attribute__((__always_inline__, __nodebug__, __target__("mmx"), __min_vector_width__(64)))

[bnoordhuis]

Untested, but a quick workaround is probably along the lines of:

diff --git a/deps/zlib/crc_folding.c b/deps/zlib/crc_folding.c
index 54f4b5c940..501dfd3101 100644
--- a/deps/zlib/crc_folding.c
+++ b/deps/zlib/crc_folding.c
@@ -23,7 +23,7 @@
 #include <immintrin.h>
 #include <wmmintrin.h>
 
-#ifndef __GNUC__
+#if defined(_WIN32) || !defined(__GNUC__)
 #define __attribute__()
 #endif
 

[targos]

I just tried with this:

diff --git a/deps/zlib/adler32_simd.c b/deps/zlib/adler32_simd.c
index f8b07297b9..d5b63727a4 100644
--- a/deps/zlib/adler32_simd.c
+++ b/deps/zlib/adler32_simd.c
@@ -50,7 +50,7 @@
 #define NMAX 5552
 
 #if defined(ADLER32_SIMD_SSSE3)
-#ifndef __GNUC__
+#if !defined(__GNUC__) && !defined(__clang__)
 #define __attribute__()
 #endif
 
diff --git a/deps/zlib/crc32_simd.c b/deps/zlib/crc32_simd.c
index 27481847e9..4c5ab42701 100644
--- a/deps/zlib/crc32_simd.c
+++ b/deps/zlib/crc32_simd.c
@@ -8,7 +8,7 @@
 #include "crc32_simd.h"
 
 #if defined(CRC32_SIMD_SSE42_PCLMUL)
-#ifndef __GNUC__
+#if !defined(__GNUC__) && !defined(__clang__)
 #define __attribute__()
 #endif
 
diff --git a/deps/zlib/crc_folding.c b/deps/zlib/crc_folding.c
index 54f4b5c940..b9d8c69b76 100644
--- a/deps/zlib/crc_folding.c
+++ b/deps/zlib/crc_folding.c
@@ -23,7 +23,7 @@
 #include <immintrin.h>
 #include <wmmintrin.h>
 
-#ifndef __GNUC__
+#if !defined(__GNUC__) && !defined(__clang__)
 #define __attribute__()
 #endif

Now got this:

crc_folding.c(251,16): warning : implicit declaration of function '_mm_shuffle_epi8' is invalid in C99 [-Wimplicit-function-declaration] [C:\Users\targo\Documen
ts\Git\nodejs\node\deps\zlib\zlib.vcxproj]
crc_folding.c(251,14): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(253,15): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(254,14): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(257,15): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de 
ps\zlib\zlib.vcxproj]
  libuv.vcxproj -> ..\..\out\Release\lib\libuv.lib
crc_folding.c(258,14): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(261,15): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(262,14): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de 
ps\zlib\zlib.vcxproj]
crc_folding.c(265,15): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de
ps\zlib\zlib.vcxproj]
crc_folding.c(266,19): error : assigning to '__m128i' (vector of 2 'long long' values) from incompatible type 'int' [C:\Users\targo\Documents\Git\nodejs\node\de 
ps\zlib\zlib.vcxproj]
crc_folding.c(502,11): warning : implicit declaration of function '_mm_extract_epi32' is invalid in C99 [-Wimplicit-function-declaration] [C:\Users\targo\Docume 
nts\Git\nodejs\node\deps\zlib\zlib.vcxproj]

[targos]

@bnoordhuis defined(_WIN32) seems to still be true with ClangCL

[targos]

I made it work with the above + adding some missing #include