Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Major and Minor-Ticks configuration #6477
Open
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In major ticks:
Please Explain in Detail...
Also what does disabled by default actually mean? The default values are still written in the table so I can expect them to be set right? I don't understand what either of these mean..
Furthermore in minor-ticks the sentence These options are disabled by default. isn't there. Does this mean only those properties which are mentioned can be used? Because that isn't the case, you can use
display: falsefor minor ticks (see here).Not only is this sentence missing but also the
enabledproperty isn't there. After some digging I found out that this property doesn't work at all either way.If we take a look at this jsfiddle, specifically at the lines 241 to 250 in the HTML (I had to do it this weird way because I wan't able to get the load order correct otherwise), you can see that I have set
enabled: falseon both theminorand themajorproperty. In the docs it says (for major ticks): If true, major tick options are used to show major ticks.. This can't be right since you can immediately see the green minor ticks and when you add data a few times and get to Sep 1 which apparently is a major ticks (again, didn't find any documentation for that) you can see that that turns red, despiteenabledbeing set tofalse.Your Proposal for Changes
I'd love to see a detailed explanation to what major and minor ticks actually are, how and where they are produced (what axes? under what conditions? what dates/format for time-axis?) and what options can and can't be used to customize those ticks. Also I think it would be good to expand on disabled by default and/or rewrite it. Then also make sure major and minor ticks are treated the same; they seem to work the same but this disabled-sentence and the
enabledproperty are missing even though the corresponding behaviour is the same.Example
The jsfiddles are already included in the text at the appropriate points.