Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Major and Minor-Ticks configuration #6477

Open
Joelius300 opened this issue Aug 20, 2019 · 0 comments
Open

Add Major and Minor-Ticks configuration #6477

Joelius300 opened this issue Aug 20, 2019 · 0 comments

Comments

@Joelius300
Copy link

@Joelius300 Joelius300 commented Aug 20, 2019

In major ticks:

The majorTick configuration is nested under the ticks configuration in the major key. It defines options for the major tick marks that are generated by the axis. Omitted options are inherited from ticks configuration. These options are disabled by default.
  • Missing or needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

  • I don't understand what These options are disabled by default. is supposed to mean.
  • I didn't find any explanation to what major and minor ticks actually are in the docs, why is that?
  • Can currently only the Time-axis produce major ticks? If so, I think this should be mentioned.

Also what does disabled by default actually mean? The default values are still written in the table so I can expect them to be set right? I don't understand what either of these mean..

  • disabled: how are they disabled? are they just undefined by default? if so, why are the default values still present in the table?
  • by default: (how) can you change it to be "enabled"?

Furthermore in minor-ticks the sentence These options are disabled by default. isn't there. Does this mean only those properties which are mentioned can be used? Because that isn't the case, you can use display: false for minor ticks (see here).
Not only is this sentence missing but also the enabled property isn't there. After some digging I found out that this property doesn't work at all either way.
If we take a look at this jsfiddle, specifically at the lines 241 to 250 in the HTML (I had to do it this weird way because I wan't able to get the load order correct otherwise), you can see that I have set enabled: false on both the minor and the major property. In the docs it says (for major ticks): If true, major tick options are used to show major ticks.. This can't be right since you can immediately see the green minor ticks and when you add data a few times and get to Sep 1 which apparently is a major ticks (again, didn't find any documentation for that) you can see that that turns red, despite enabled being set to false.

Your Proposal for Changes

I'd love to see a detailed explanation to what major and minor ticks actually are, how and where they are produced (what axes? under what conditions? what dates/format for time-axis?) and what options can and can't be used to customize those ticks. Also I think it would be good to expand on disabled by default and/or rewrite it. Then also make sure major and minor ticks are treated the same; they seem to work the same but this disabled-sentence and the enabled property are missing even though the corresponding behaviour is the same.

Example

The jsfiddles are already included in the text at the appropriate points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.