Skip to content

/ freeCodeCamp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update a few challenges' test texts to wrap certain values in code tags to prevent translation in other languages #38312

Open
RandellDawson opened this issue Mar 2, 2020 · 4 comments · May be fixed by #38316
Open

Need to update a few challenges' test texts to wrap certain values in code tags to prevent translation in other languages #38312

RandellDawson opened this issue Mar 2, 2020 · 4 comments · May be fixed by #38316
Labels
language: English scope: learn

Comments

@RandellDawson
Copy link
Member

@RandellDawson RandellDawson commented Mar 2, 2020 •
edited

Following up on the comment on PR 38309, the following English challenge tests need to be updated as described, as the non-English version were translating these when they should not have been translated.

  • Standardize Times with the HTML5 datetime Attribute
    Issues: All tests need to be re-translated

  • Use the strong Tag to Make Text Bold
    Issues: "Stanford University" needs code tags so it is not translated.

  • Add a Submit Button to a Form
    Issues: "Submit" needs code tags so it is not translated

  • Add Placeholder Text to a Text Field
    Issues: "cat photo URL" needs code tags so it is not translated

  • Create an Ordered List
    Issues: The first test text "Top 3 things cats hate:" needs code tags so it is not translated. The same goes for the second test text "Things cats love:"

  • Headline with the h2 Element
    Issues: The third test text "CatPhotoApp" needs code tags so it is not translated.

  • Inform with the Paragraph Element
    Issues: The second test text "Hello Paragraph" needs code tags so it is not translated.

  • Use the u Tag to Underline Text
    Issues: The second test text "Ph.D. students" needs code tags so it is not translated.
@millwala53
Copy link

@millwala53 millwala53 commented Mar 3, 2020

I would like to work on this issue, please.
@millwala53
Copy link

@millwala53 millwala53 commented Mar 3, 2020

@RandellDawson I have managed to fix all the issues, just need some clarification related to the first issue.
Standardize Times with the HTML5 datetime Attribute, When you say all tests need to be re-translated do you mean that the important text in each test e.g "Thursday, September 15<sup>th</sup>" in test 2 need to be wrapped in a code tag so they aren't translated?
@Sky020 Sky020 linked a pull request that will close this issue Mar 3, 2020
Open
2 of 2 tasks complete
@RandellDawson
Copy link
Member Author

@RandellDawson RandellDawson commented Mar 3, 2020

@millwala53 I mean the Chinese version of this challenge was never updated with the changes made to the English version on June 28th, 2019. This means the all of the text needs to be modified so that the parts in quotes are surrounded by code tags and the rest gets translated to Chinese. Also, in the last test 2016-09-15 should be surrounded with code tags.
@RandellDawson
Copy link
Member Author

@RandellDawson RandellDawson commented Mar 3, 2020

@millwala53 In the time I wrote my last comment @Sky020 created a PR to resolve this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: English scope: learn
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix(learn): Added code tags to translated texts
3 participants
@RandellDawson @ojeytonwilliams @millwala53
You can’t perform that action at this time.