Skip to content

/ gvisor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beef up write syscall tests #2370

Open
fvoznika opened this issue Apr 8, 2020 · 0 comments
Open

Beef up write syscall tests #2370

fvoznika opened this issue Apr 8, 2020 · 0 comments
Labels
area: filesystem area: tests good first issue type: cleanup

Comments

@fvoznika
Copy link
Member

@fvoznika fvoznika commented Apr 8, 2020

There are only a few basic syscall tests for write(2) and pwrite(2). Here is an incomplete list of missing tests:

  • bad buffer states (EFAULT).
  • bad fds (wrong permission, wrong type of file, EBADF).
  • check offset is incremented.
  • check for EOF.
  • writing to pipes, symlinks, special files.
@dragoneena12 dragoneena12 mentioned this issue Jun 16, 2020
Open
jinmouil added a commit to jinmouil/gvisor that referenced this issue Jun 25, 2020
@jinmouil
google#2370 add offset tests and pwrite for symlink
2cf6ac6
jinmouil added a commit to jinmouil/gvisor that referenced this issue Jun 25, 2020
@jinmouil
google#2370 add offset tests and pwrite for symlink
838ff42
@avagin avagin added kokoro:run and removed kokoro:run labels Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: filesystem area: tests good first issue type: cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@avagin @fvoznika
You can’t perform that action at this time.