Skip to content

/ react-refetch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for React 16.3 getDerivedStateFromProps #199

Open
wmonk opened this issue Apr 9, 2018 · 2 comments
Open

Add support for React 16.3 getDerivedStateFromProps #199

wmonk opened this issue Apr 9, 2018 · 2 comments

Comments

@wmonk
Copy link

@wmonk wmonk commented Apr 9, 2018

When using getDerivedStateFromProps the lifecycle methods of react-refetch are not called.

I suppose react-refetch should be updated to use the appropriate methods.
@wmonk
Copy link
Author

@wmonk wmonk commented Apr 9, 2018

Possibly also need to update hoist-non-react-statics
@horyd
Copy link

@horyd horyd commented Apr 10, 2018

Yea I noticed when I tried 16.3 that none of the my PromiseStates were included in the props at all :S
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@wmonk @horyd
You can’t perform that action at this time.