Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to upsert ECR stack during the deployment phase #303

Open
rmc3 opened this issue Apr 10, 2018 · 0 comments
Open

Attempting to upsert ECR stack during the deployment phase #303

rmc3 opened this issue Apr 10, 2018 · 0 comments

Comments

@rmc3
Copy link
Contributor

@rmc3 rmc3 commented Apr 10, 2018

When the ECR stack was not upserted during the build phase, mu will attempt to upsert it during the deploy phase. This can cause potentially confusing behavior, such as mu being unable to create the ECR stack because the IAM roles created previously don't have the necessary permissions. This behavior can be triggered by building a pipeline with the ecs provider that does not have a Dockerfile, since the presence of a Dockerfile is what triggers the creation of the ECS/ECR resources during the build phase.

If there's no valid reason mu should attempt to upsert the ECR stack during mu svc deploy, a potential improvement might be to have it only attempt to resolve the image from ECR and throw an error if it doesn't exist without attempting to create the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.