Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAttempting to upsert ECR stack during the deployment phase #303
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the ECR stack was not upserted during the build phase, mu will attempt to upsert it during the deploy phase. This can cause potentially confusing behavior, such as mu being unable to create the ECR stack because the IAM roles created previously don't have the necessary permissions. This behavior can be triggered by building a pipeline with the
ecsprovider that does not have aDockerfile, since the presence of aDockerfileis what triggers the creation of the ECS/ECR resources during the build phase.If there's no valid reason mu should attempt to upsert the ECR stack during
mu svc deploy, a potential improvement might be to have it only attempt to resolve the image from ECR and throw an error if it doesn't exist without attempting to create the stack.