Skip to content

/ awesome-compose

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding simple Traefik example. #44

Merged
merged 3 commits into from Apr 7, 2020
Merged

Adding simple Traefik example. #44

merged 3 commits into from Apr 7, 2020

Conversation

@lfache
Copy link
Contributor

@lfache lfache commented Apr 7, 2020

Just add a simple Traefik reverse proxy example like nginx golang
@glours
glours requested changes Apr 7, 2020
View changes
Copy link
Collaborator

@glours glours left a comment

Can you update the main README.md to add your sample in the Single service samples section please?
Can you sign off your commit please (git commit --amend -s --no-edit)?
traefik-golang/docker-compose.yml Show resolved Hide resolved
@glours
Copy link
Collaborator

@glours glours commented Apr 7, 2020

@lfache I just need you fix the DCO issue to merge your PR
Thank you very much for your contribution 👍
lfache added 2 commits Apr 7, 2020
@lfache
Adding simple Traefik example.
bd92c49 
Signed-off-by: lfache <[email protected]>
@lfache
Update README.md
Loading status checks…
8a1f8e4 
Signed-off-by: lfache <[email protected]>
@lfache lfache force-pushed the lfache:master branch from e3e9651 to 8a1f8e4 Apr 7, 2020
@glours
Copy link
Collaborator

@glours glours commented Apr 7, 2020

Arff now there's a conflit in the README.md, can you rebase with master please?
@lfache
Merge branch 'master' of https://github.com/docker/awesome-compose
Loading status checks…
8d5a60c
@glours glours merged commit 3a0f551 into docker:master Apr 7, 2020
1 check passed
1 check passed
DCO DCO
Details
@glours
Copy link
Collaborator

@glours glours commented Apr 7, 2020

Thanks 🙏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez

@glours glours

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@lfache @glours @ldez
You can’t perform that action at this time.