Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify help links to choose a more specific factory method #76

Open
zspitz opened this issue Jun 26, 2019 · 0 comments
Open

Modify help links to choose a more specific factory method #76

zspitz opened this issue Jun 26, 2019 · 0 comments

Comments

@zspitz
Copy link
Owner

@zspitz zspitz commented Jun 26, 2019

Currently, (except for BinaryExpression and UnaryExpression which return the method based on the expression's NodeType) all factory methods which return the same object type as the node are displayed. For example, MemberExpression displays:

  • Field
  • MakeMemberAccess
  • Property
  • PropertyOrField

It might be better to show only the specific method that applies to this node, duplicating the logic of the factory methods formatter.

OTOH, as long as there aren't too many, it might be better to show all these possibilities.

@zspitz zspitz changed the title Help link to more specific factory method Modify help links to choose a more specific factory method Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.