Fixed test script for DevTools build config#19295
Merged
bvaughn merged 1 commit intofacebook:masterfrom Jul 9, 2020
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
bvaughn
commented
Jul 9, 2020
| // Add the correct Jest config. | ||
| const args = ['./scripts/jest/jest.js', '--config']; | ||
| if (argv.build) { | ||
| if (argv.project === 'devtools') { |
Contributor
Author
There was a problem hiding this comment.
DevTools always uses the build config, but not vice versa, so it needs to come first.
Having one if/else condition flow for two flags seems a bit fragile, but I didn't want to make a larger change here because I'm in the middle of testing a DevTools release.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 693ac40:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19293