Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: add carousel wc following basic and tabbed pattern #3438
+3,336
−48
Conversation
dfb329b
to
c20ad9b
4a4f2d7
to
2ef3091
c7f84ae
to
1449ba4
...ts/fast-components/src/utilities/components/carousel-test-slide/index.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-foundation/src/carousel/carousel.template.ts
Outdated
Show resolved
Hide resolved
packages/web-components/fast-components/src/carousel/fixtures/base.html
Outdated
Show resolved
Hide resolved
03a5296
to
e594270
added 24 commits
Jul 3, 2020
…with keyboard
…indin to fix out of sync error
… pattern, reordered for proper tab sequence, fixed tab not focusing on first keyboard increment
… tab sequence reorder, corrected change emitting
…itions for components explorer
…lt flipper buttons
…test__
beda911
to
b8f1c5a
| * HTML Attribute: loop | ||
| */ | ||
| @attr({ mode: "fromView" }) | ||
| public loop: boolean = true; |
This comment has been minimized.
This comment has been minimized.
janechu
Aug 6, 2020
Member
Just catching this, I don't believe we can set attributes like this, you have to wait for the connectedCallback to initialize them. See #3494 as an example
81c1156
to
05f9474
05f9474
to
79fd4fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SethDonohue commentedJul 3, 2020
•
edited
Description
Motivation & context
This adds the Carousel web component with both the Basic and Tabbed patterns of ARIA as defined here:
https://w3c.github.io/aria-practices/#carousel
https://w3c.github.io/aria-practices/#basic-carousel-elements
https://w3c.github.io/aria-practices/#tabbed-carousel-elements
It adds a Carousel Test Slide component for use in the Carousel Fixtures.
This ALSO required some minor non-breaking changes to Tabs listed below:
This ALSO requires changes to Flipper:
Questions: Please comment on this!
Should we expose methods for the author to implement their own custom methods for flexibility?
Or should all/any of the above methods baked in to the controller and strictly controlled per ARIA spec?
Notes:
The Carousel pauses rotation whenever the mouse is over the carousel OR the content is in focus.
Per ARIA spec it also stops rotation anytime keyboard focus is brought to any part of the carousel, AND is not restarted unless the user specifically activates the rotation control button.
With that in mind I have chosen to interpret it as to NOT restart the rotation when keyboard focus leaves as this may be a disruptive feature for AT users.
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist