Skip to content

/ seq2seq

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GLEU score #34

Open
alvations opened this issue Mar 14, 2017 · 3 comments
Open

Adding GLEU score #34

alvations opened this issue Mar 14, 2017 · 3 comments
Labels
feature

Comments

@alvations
Copy link

@alvations alvations commented Mar 14, 2017

nltk has a simple implementation of GLEU score as described in Wu et al.'s (2016) GMNT system: https://github.com/nltk/nltk/blob/develop/nltk/translate/gleu_score.py

It'll be great if the seq2seq has a similar port of GLEU =)
@dennybritz
Copy link
Contributor

@dennybritz dennybritz commented Mar 14, 2017

Yup, would be a good addition to BLEU and ROUGE. I don't want to make NLTK a dependency, but it's simple enough to just add from scratch.
@dennybritz dennybritz added the feature label Mar 14, 2017
@alvations
Copy link
Author

@alvations alvations commented Mar 14, 2017

Is there a particular place (directory) to put metrics and significance computation scripts?
@dennybritz
Copy link
Contributor

@dennybritz dennybritz commented Mar 14, 2017 •
edited

Yeah, in metrics. After adding the metric as a python function there you also need to add a MetricSpec that can be used with Tensorflow, like this,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@dennybritz @alvations
You can’t perform that action at this time.