Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Format shell scripts #699

Merged
merged 1 commit into from Jul 16, 2020
Merged

refactor: Format shell scripts #699

merged 1 commit into from Jul 16, 2020

Conversation

@HowJMay
Copy link
Contributor

@HowJMay HowJMay commented Jul 8, 2020

Using 'shfmt' to format shell scripts
See: https://github.com/mvdan/sh for more information

We may need to add this into formatter

@jserv
Copy link
Member

@jserv jserv commented Jul 8, 2020

I tend to merge this pull request first and then others such as #642 in turn. OK?

@HowJMay HowJMay force-pushed the HowJMay:fmt_shell branch 3 times, most recently from 1f74782 to 1fbcde9 Jul 9, 2020
@HowJMay
Copy link
Contributor Author

@HowJMay HowJMay commented Jul 9, 2020

I tend to merge this pull request first and then others such as #642 in turn. OK?

I have removed the dependency on #642

@HowJMay HowJMay marked this pull request as ready for review Jul 9, 2020
Copy link
Member

@jserv jserv left a comment

Fix conflicts

@HowJMay HowJMay force-pushed the HowJMay:fmt_shell branch 2 times, most recently from 20df464 to 90be680 Jul 9, 2020
Copy link
Member

@jserv jserv left a comment

Update file CONTRIBUTING.md for indenting shell scripts

@HowJMay HowJMay force-pushed the HowJMay:fmt_shell branch 6 times, most recently from aa76acd to b591d09 Jul 16, 2020
Using 'shfmt' to format shell scripts
See: https://github.com/mvdan/sh for more information
@HowJMay HowJMay force-pushed the HowJMay:fmt_shell branch from b591d09 to 6582608 Jul 16, 2020
@jserv jserv merged commit 782a6e7 into DLTcollab:develop Jul 16, 2020
13 checks passed
13 checks passed
buildkite/tangle-accelerator-pr/pr Build #3618 passed (5 minutes, 35 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-asan Passed (1 minute, 57 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-db-enable-asan Passed (1 minute, 57 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-db-enable-ubsan Passed (1 minute, 49 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-mqtt-enable-asan Passed (2 minutes, 38 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-mqtt-enable-tsan Passed (5 minutes, 34 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-mqtt-enable-ubsan Passed (2 minutes, 36 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-tsan Passed (5 minutes, 27 seconds)
Details
buildkite/tangle-accelerator-pr/pr/bazel-test-ubsan Passed (2 minutes, 20 seconds)
Details
buildkite/tangle-accelerator-pr/pr/code-style Passed (5 seconds)
Details
buildkite/tangle-accelerator-pr/pr/endpoint-regression-test Passed (37 seconds)
Details
buildkite/tangle-accelerator-pr/pr/test-endpoint-app-on-development-host Passed (2 minutes, 42 seconds)
Details
buildkite/tangle-accelerator-pr/pr/test-endpoint-app-on-wp77xx Passed (37 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.