Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel] Add support for compatible_with and restricted_to #5681

Merged
merged 2 commits into from Dec 26, 2019

Conversation

@AustinSchuh
Copy link
Contributor

@AustinSchuh AustinSchuh commented Dec 26, 2019

These attributes have been available in Bazel for years. Pass them
through so the flatbuffer rules can be used with them. They let you
constrain which target platform is used.

While we are here, fix gen_reflections to work with bazel.

@googlebot
Copy link

@googlebot googlebot commented Dec 26, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

These attributes have been available in Bazel for years.  Pass them
through so the flatbuffer rules can be used with them.  They let you
constrain which target platform is used.

While we are here, fix gen_reflections to work with bazel.
@AustinSchuh AustinSchuh force-pushed the AustinSchuh:austin/compatible_with branch from ba9f442 to bd4d3fb Dec 26, 2019
@googlebot
Copy link

@googlebot googlebot commented Dec 26, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aardappel
Copy link
Collaborator

@aardappel aardappel commented Dec 26, 2019

Thanks!
(CI fail is unrelated).

@aardappel aardappel merged commit 62ec7d5 into google:master Dec 26, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
buildkite/flatbuffers/pr Build #1332 passed (43 seconds)
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
LuckyRu added a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
* Add support for compatible_with and restricted_to

These attributes have been available in Bazel for years.  Pass them
through so the flatbuffer rules can be used with them.  They let you
constrain which target platform is used.

While we are here, fix gen_reflections to work with bazel.

* Add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.