Skip to content

/machinelearning

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime exception in ImageClassification. #3249

Merged
merged 4 commits into from Apr 9, 2019
+67 −3

Conversation

@codemzs
Copy link
Member

codemzs commented Apr 8, 2019

fixes #3248
@codemzs
Fix runtime exception in ImageClassification.
Loading status checks…
893333e
@codemzs codemzs requested review from sfilipi and zeahmed Apr 8, 2019
codemzs added 2 commits Apr 8, 2019
@codemzs
Cleanup.
Loading status checks…
b69216a
@codemzs
revert changes.
Loading status checks…
5d35b06
@zeahmed
zeahmed reviewed Apr 8, 2019
View changes
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/ImageClassification.cs Show resolved Hide resolved
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Apr 8, 2019 •
edited

Codecov Report

Merging #3249 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
+ Coverage   72.61%   72.62%   +<.01%     
==========================================
  Files         804      807       +3     
  Lines      145025   145080      +55     
  Branches    16213    16213              
==========================================
+ Hits       105314   105368      +54     
- Misses      35294    35295       +1     
  Partials     4417     4417
Flag Coverage Δ
#Debug 72.62% <ø> (ø) ⬆️
#production 68.17% <ø> (+0.01%) ⬆️
#test 88.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.21%) ⬇️
...OnnxTransformer.StaticPipe/OnnxStaticExtensions.cs 100% <0%> (ø)
...L.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs 100% <0%> (ø)
...r.StaticPipe/DnnImageFeaturizerStaticExtensions.cs 100% <0%> (ø)
@zeahmed
zeahmed approved these changes Apr 8, 2019
View changes
Copy link
Member

zeahmed left a comment

:shipit:
@codemzs codemzs requested a review from wschin Apr 8, 2019
@wschin
wschin approved these changes Apr 8, 2019
View changes
@wschin
wschin reviewed Apr 8, 2019
View changes
docs/samples/Microsoft.ML.Samples/Dynamic/TensorFlow/ImageClassification.cs Show resolved Hide resolved
@codemzs
3P license notice.
Loading status checks…
a3201ea
@codemzs codemzs merged commit ee14339 into dotnet:master Apr 9, 2019
3 of 4 checks passed
3 of 4 checks passed
MachineLearning-CodeCoverage in progress
Details
MachineLearning-CI #20190409.9 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
@codemzs
Fix runtime exception in ImageClassification. (dotnet#3249)
bfa23db 
* Fix runtime exception in ImageClassification.

* Cleanup.

* revert changes.

* 3P license notice.
@codemzs codemzs referenced this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wschin wschin

@zeahmed zeahmed

@sfilipi sfilipi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@codemzs @wschin @zeahmed
You can’t perform that action at this time.